srvrco / getssl

obtain free SSL certificates from letsencrypt ACME server Suitable for automating the process on remote servers.
GNU General Public License v3.0
2.1k stars 378 forks source link

Joker dns scripts not working #747

Open akselii opened 2 years ago

akselii commented 2 years ago

Describe the bug Current joker dns scripts are not working.

To Reproduce Try to use the dns_add/del_joker scripts, wont work.

I tried to fix the scripts, and i was able to get my certs. Reading through https://joker.com/faq/content/6/496/en/let_s-encrypt-support.html I came up with this for the dns_add_joker:

curl -X POST https://svc.joker.com/nic/replace -d "username=${USERNAME}&password=${PASSWORD}&zone=${DOMAIN_ROOT}&label=_acme-challenge&type=TXT&value=${TOKEN}" 2>&1

and this for dns_del_joker:

curl -X POST https://svc.joker.com/nic/replace -d "username=${USERNAME}&password=${PASSWORD}&zone=${DOMAIN_ROOT}&label=_acme-challenge&type=TXT&value=" 2>&1

I just replaced everything after the DOMAIN_ROOT line on both scripts with that single curl line. While i was able to get my certs with these updated scripts, im not sure if they are actually correct.

timkimber commented 2 years ago

Hi @akselii

Thanks for reporting this - I'll see if I can request a test account (or similar) from Joker dns so that I can test the changes you suggest

akselii commented 2 years ago

Ah, do note that im using ${DOMAIN_ROOT}, im not sure if it should be ${FULLDOMAIN}. I have no idea how this cert stuff works, just got into it couple of days ago.

Anyways, I was able to request mydomain.com and *.mydomain.com, didnt try a subdomain.mydomain.com