srvrco / getssl

obtain free SSL certificates from letsencrypt ACME server Suitable for automating the process on remote servers.
GNU General Public License v3.0
2.09k stars 374 forks source link

acme-dns: improve cURL error handling #811

Closed loganmzz closed 10 months ago

loganmzz commented 1 year ago

Hello,

A very small change (at the moment, see below) in order to improve cURL error handling. cURL isn't a good HTTP client in regard of how to catch misc errors. This PR add common pattern around error handling with cURL:

Discussion about this PR is highly open, but some interesting point that need to be discussed: