srwi / EverythingToolbar

Everything integration for the Windows taskbar.
Other
9.49k stars 412 forks source link

Misaligned launcher search window #328

Closed eljesus111 closed 1 year ago

eljesus111 commented 1 year ago

Preflight Checklist

Problem Description

*

Proposed Solution

I saw that i can resize and place the start menu at any part of the screen, so why not making that position permanent? It would be cool to have the search menu at any part of the screen, it would be waaay more comfortable than the original start menu.

Alternatives Considered

*

Additional Information

*

TeacherGalante commented 1 year ago

Yes, something similar to the way that SystemTrayMenu allows you to reposition its menu and remembers it would be great.

srwi commented 1 year ago

I must honestly say I don't really like the idea. EverythingToolbar is meant to mimic the behavior of the original Windows search and therefore positions itself near the search icon/box. Allowing the user to place the windows freely would require an additional option/button to revert the behavior to automatic placement.

What would be a scenario where you want to place the search window away from the search icon/box?

TeacherGalante commented 1 year ago

I am attaching a screenshot of my desktop. I'm really more asking for the toolbar to pop up centred or aligned with the pinned toolbar icon. I think my main issue is that being left-aligned (aligned with the left edge of the start bar) feels "off" when I am able to centre-align the icons. I did try left-aligning the start bar, then re-centring them, but that did not re-align the toolbar popup. Does that explanation make sense? desktop-why-move-the-everything-toolbar

eljesus111 commented 1 year ago

I must honestly say I don't really like the idea. EverythingToolbar is meant to mimic the behavior of the original Windows search and therefore positions itself near the search icon/box. Allowing the user to place the windows freely would require an additional option/button to revert the behavior to automatic placement.

What would be a scenario where you want to place the search window away from the search icon/box?

Well, basically the dude above me answered for me. I mean, it would be waaaaaaaay easier to customize your ui (centering the menu as an example)

srwi commented 1 year ago

@TeacherGalante Actually the search window should be placed in the middle of the screen in your case. Could you please attach the contents of the log file (%TEMP%\EverythingToolbar.log) and check the registry HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarAl? For a center aligned taskbar the value should be 1.

eljesus111 commented 1 year ago

@TeacherGalante Actually the search window should be placed in the middle of the screen in your case. Could you please attach the contents of the log file (%TEMP%\EverythingToolbar.log) and check the registry HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarAl? For a center aligned taskbar the value should be 1.

it would be cool a centered search menu on windows 10, mixed with explorer patcher's centered start menu.

TeacherGalante commented 1 year ago

@srwi

@TeacherGalante Actually the search window should be placed in the middle of the screen in your case. Could you please attach the contents of the log file (%TEMP%\EverythingToolbar.log) and check the registry HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarAl? For a center aligned taskbar the value should be 1.

Contents of the log file: 2023-02-18 14:59:56.5197|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-18 15:01:29.5833|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1|

The registry value for TaskbarA1 was set to 0; I manually edited the value to 1 and restarted the system. It did not fix the issue.

srwi commented 1 year ago

@srwi

@TeacherGalante Actually the search window should be placed in the middle of the screen in your case. Could you please attach the contents of the log file (%TEMP%\EverythingToolbar.log) and check the registry HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\TaskbarAl? For a center aligned taskbar the value should be 1.

Contents of the log file: 2023-02-18 14:59:56.5197|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-18 15:01:29.5833|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1|

The registry value for TaskbarA1 was set to 0; I manually edited the value to 1 and restarted the system. It did not fix the issue.

Sorry, I forgot to ask which build version of Windows 11 are you running?

I must admit, I don't see any reason why it would align itself on the left side. It should be center-aligned if you are running Windows 11 (at least build number 22000) and the registry key TaskbarAl has value 1. Are you sure the registry key exists under TaskbarAl (as in "TaskbarAlignment") and not TaskbarA1?

TeacherGalante commented 1 year ago

@srwi Wellllll...now that you mention it, there is no "TaskbarAlignment" under the HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\ branch. I'll add it, set it to "1", and let you know how it goes.

[edit]

Adding the dvalue "TaskbarAlignment" and setting it to 1 did not change Everythingbar's alignment.

TeacherGalante commented 1 year ago

I apologise I didn't see your request earlier for the Windows version. It is: Edition Windows 11 Home Version 22H2 Installed on ‎05/‎10/‎2022 OS build 22621.1265 Experience Windows Feature Experience Pack 1000.22638.1000.0

srwi commented 1 year ago

Sorry for my slow responses regarding this issue. I am still a little clueless here. I just published a new release 1.0.3 of EverythingToolbar. I added some more debugging output to hopefully get to the bottom of this. It would be great if you could help me by doing the following:

If the file debug.txt was created correctly, the log file should contain a line "Debug logging enabled.".

eljesus111 commented 1 year ago

i have no idea what to say

adrynalyne commented 1 year ago

@srwi I have the same issue/concern. My TaskbarAl is set to 1, and I am on Windows 11 with a centered taskbar. EverythingToolbar opens to the top left on my ultrawide monitor. Other times it will open in the center, and other items it will be halfway off the screen. I am running 1.0.3, and I tried enabling the debug.txt but nothing was ever written to it.

I tried the following locations: %APPDATA%\EverythingToolbar\debug.txt --This required building the directory structure first. %LOCALAPPDATA%\EverythingToolbar\debug.txt --This directory existed already, but still nothing was written. I restarted Everything Toolbar and even rebooted.

srwi commented 1 year ago

I am running 1.0.3, and I tried enabling the debug.txt but nothing was ever written to it.

Sorry, I could have expressed myself better. Nothing will be written to the debug.txt file. It is rather just a flag that lets EverythingToolbar know it should write debug output to the regular log file, which is located at %TEMP%\EverythingToolbar.log

adrynalyne commented 1 year ago

Gotcha.

Here is my log, a lot might be redundant:

2023-02-28 06:25:06.4019|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:25:06.7353|ERROR|EverythingToolbar.Helpers.ShortcutManager|Failed to register hotkey.|NHotkey.HotkeyAlreadyRegisteredException: Hot key is already registered. (Exception from HRESULT: 0x80070581) ---> System.Runtime.InteropServices.COMException: Hot key is already registered. (Exception from HRESULT: 0x80070581) --- End of inner exception stack trace --- at NHotkey.Hotkey.Register(IntPtr hwnd, String name) at NHotkey.HotkeyManagerBase.AddOrReplace(String name, UInt32 virtualKey, HotkeyFlags flags, EventHandler1 handler) at EverythingToolbar.Helpers.ShortcutManager.AddOrReplace(String name, Key key, ModifierKeys modifiers, EventHandler1 handler) in C:\Users\Stephan\Entwicklung\EverythingToolbar\EverythingToolbar\Helpers\ShortcutManager.cs:line 69 2023-02-28 06:26:52.0859|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:27:02.4814|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:28:37.2261|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:31:45.7069|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:32:04.1085|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 06:33:03.2113|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 06:34:35.7527|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 06:37:05.8138|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:03:40.1294|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:03:48.3520|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 08:10:13.0543|DEBUG|ToolbarLogger|Debug logging enabled.| 2023-02-28 08:10:13.0868|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:12:23.0571|DEBUG|ToolbarLogger|Debug logging enabled.| 2023-02-28 08:12:23.0891|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:12:32.1865|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:12:32.2800|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:14:40.0387|DEBUG|ToolbarLogger|Debug logging enabled.| 2023-02-28 08:14:40.0772|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:14:49.5938|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:14:49.9031|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:15:33.9204|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:16:03.2874|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:16:25.4793|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:16:52.4835|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:17:05.9068|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:17:17.2544|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:17:42.0425|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 08:30:15.5451|DEBUG|ToolbarLogger|Debug logging enabled.| 2023-02-28 08:30:15.5816|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 08:33:13.7586|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 08:33:13.9929|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712| 2023-02-28 12:12:23.9272|DEBUG|ToolbarLogger|Debug logging enabled.| 2023-02-28 12:12:23.9687|INFO|Launcher|EverythingToolbar Launcher 1.0.3.0 started. OS: Microsoft Windows NT 10.0.22621.0| 2023-02-28 12:13:57.7088|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|Calculating window position...| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Edge: Left| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|taskbar.Position: {X=0,Y=0,Width=1,Height=1600}| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|margin: 12| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|windowSize: 812, 700| 2023-02-28 12:13:57.9248|DEBUG|EverythingToolbar.Launcher.SearchWindowPlacement|position: 13, position.Right: 825, position.Top: 12, position.Bottom: 712|

srwi commented 1 year ago

@adrynalyne It looks like there is some application pinned to the left screen edge with a width of one pixel. This tricks EverythingToolbar into thinking the taskbar was vertical at the left edge of the screen. Can you imagine which application could be causing this? My first thought was the Windows widgets sidebar, but I can't reproduce the problem by enabling that on my machine.

In @TeacherGalante's screenshot I see applications like maybe Rainmeter causing that.

In the end it's hard for me to say what exactly is causing this, but I can probably fix this for most cases by prioritizing the bottom over the left taskbar position.

TeacherGalante commented 1 year ago

@adrynalyne It looks like there is some application pinned to the left screen edge with a width of one pixel. This tricks EverythingToolbar into thinking the taskbar was vertical at the left edge of the screen. Can you imagine which application could be causing this? My first thought was the Windows widgets sidebar, but I can't reproduce the problem by enabling that on my machine.

In @TeacherGalante's screenshot I see applications like maybe Rainmeter causing that.

In the end it's hard for me to say what exactly is causing this, but I can probably fix this for most cases by prioritizing the bottom over the left taskbar position.

I tried disabling Rainmeter; the same issue occurs.

One other item of note: whenever I attempt to change the alignment of the start bar in Windows's settings, it automatically resets back to left alignment immediately. For example, I click centre alignment; Windows allows the dropdown to select centre alignment; immediately, Windows resets the setting to left alignment while I am looking at the screen.

srwi commented 1 year ago

One other item of note: whenever I attempt to change the alignment of the start bar in Windows's settings, it automatically resets back to left alignment immediately. For example, I click centre alignment; Windows allows the dropdown to select centre alignment; immediately, Windows resets the setting to left alignment while I am looking at the screen.

There seems to be an unrelated problem with your Windows installation, probably caused by some other application.

I implemented a workaround that I expect to fix the issues related to EverythingToolbar. It will be available in the next release. I will close this issue now. If it does not solve the problem, please open another bug report.