srwi / EverythingToolbar

Everything integration for the Windows taskbar.
Other
9.49k stars 412 forks source link

Everything Toolbar does not call correct File Handler when Default File Handler has ben Changed #373

Closed Foxxsayy closed 1 year ago

Foxxsayy commented 1 year ago

Preflight Checklist

EverythingToolbar Version

1.0.3.0

Windows Version

Windows 11 Home, Version 22H2

Steps to reproduce

Click on any folder in the Everything Search Toolbar to replicate.

If the default file manager has been changed, clicking on a folder in the Everything Search Toolbar will not open it. For instance, if a user has Directory Opus set to be their default file manager, clicking a folder in the everything searched for bar still opens it in Windows File Explorer.

I confirmed that the base Everything program works as expected will call the default file handler. My guess is that the Everything Search Toolbar is currently coded to call Windows File Explorer explicitly rather than calling for the default file manager.

Expected Behavior

When a folder is clicked/opened via the Everything Toolbar, open it with the default file manager. [e.g., Directory Opus, Total Commander, etc.]

Actual Behavior

When a folder is clicked/opened via the Everything Toolbar, it opens in Windows File Explorer regardless of default file manager.

Screenshots

N/A

Log output

N/A

Additional Information

N/A

Horst12 commented 1 year ago

Make a simple rule for folders and you have it. My rule for Total Commander looks like this Screenshot - 18 04 2023 , 22_11_05

Foxxsayy commented 1 year ago

Make a simple rule for folders and you have it.

@Horst12 Thanks for the tip! that's a good workaround. Can I see the rest of what you wrote for TC Folder? I'm good with Boolean operators, but I'm not great with RegEx or CMD or Path Syntax.

For the RegEx, what does the ^.&$ mean? (It looks like the strings you have in place for TC, XY, and Edit are specifying the file types to use with that command?) In the Command section, it looks like a standard program call, but I'm not sure what the /a /o /s and %file% modifiers do?

*(I accidentally hit close issue so I reopened it. Since this is the way Everything works, I feel like it might be an oversight or should just be the default behavior so I'll wait for Stephan's input before closing it).

srwi commented 1 year ago

I tried fixing this a while ago already. I think this time I did it correctly. Thanks for reminding me to look into it again!

Foxxsayy commented 1 year ago

I tried fixing this a while ago already. I think this time I did it correctly. Thanks for reminding me to look into it again!

Thanks! I assume the fix will be in the next release?

srwi commented 1 year ago

Yes, exactly.