srwi / EverythingToolbar

Everything integration for the Windows taskbar.
Other
8.97k stars 404 forks source link

Certain circumstances will cause the text box to temporarily disappear. #425

Closed YamatoRyou closed 11 months ago

YamatoRyou commented 11 months ago

Preflight Checklist

EverythingToolbar Version

1.2.0.0

Everything Version

1.4.1.1023

Windows Version

Windows 11 (10.0.22621)

Steps to reproduce

  1. Edit the value of TextBoxMaxHeight in \Themes\Win11\Controls\TextBox.xaml, I changed it to 28. This will cause the height of the text box to be smaller than the height of the taskbar, leaving a blank space above and below the text box;
  2. Restart the desktop;
  3. Let the text box get the focus first, and then right-click the blank part.

Expected Behavior

n/a

Actual Behavior

Textbox disappear. Temporary workaround is to change taskbar lock state.

Screenshots

{17DB662E-D260-F666-B077-E446500CFABF}

Log output

2023-07-30 5:11:12.4270|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.2.0.0 started. OS: Microsoft Windows NT 10.0.22621.0|
2023-07-30 5:29:58.9802|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1|

EOF

Additional Information

Use StartAllBack to force the taskbar to change to Windows 10 style, to ensure that the text box can be resident on the taskbar.

srwi commented 11 months ago

I can not seem to reproduce the problem you are having. In the video it looks like you are using the Windows 10 theme. What exactly are you trying to do?

YamatoRyou commented 11 months ago

I can not seem to reproduce the problem you are having. In the video it looks like you are using the Windows 10 theme. What exactly are you trying to do?

147

Forced to upgrade to Windows 11 for some reason, but I refuse to use the new taskbar. Resizing the textbox height is a long-standing wish.

srwi commented 11 months ago

I can achieve a slimmer search box by swapping the theme folder names Win11 and Win10 and afterwards changing the content of the file that is now called Themes/Win11/Controls/TextBox.xaml to:

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:Sys="clr-namespace:System;assembly=mscorlib">

    <Thickness x:Key="TextBoxBorderActiveThickness"
               Bottom="2"
               Top="2"
               Left="2"
               Right="2" />
    <CornerRadius x:Key="TextBoxCornerRadius" />
    <Sys:Double x:Key="TextBoxMaxHeight">28</Sys:Double>

    <ResourceDictionary.MergedDictionaries>
        <ResourceDictionary Source="../../../Styles/TextBox.xaml" />
    </ResourceDictionary.MergedDictionaries>

</ResourceDictionary>

grafik

This way I can not reproduce the problem you are having. Please reinstall EverythingToolbar and try to do it like this.

YamatoRyou commented 11 months ago

I can achieve a slimmer search box by swapping the theme folder names Win11 and Win10 and afterwards changing the content of the file that is now called Themes/Win11/Controls/TextBox.xaml to:

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:Sys="clr-namespace:System;assembly=mscorlib">

    <Thickness x:Key="TextBoxBorderActiveThickness"
               Bottom="2"
               Top="2"
               Left="2"
               Right="2" />
    <CornerRadius x:Key="TextBoxCornerRadius" />
    <Sys:Double x:Key="TextBoxMaxHeight">28</Sys:Double>

    <ResourceDictionary.MergedDictionaries>
        <ResourceDictionary Source="../../../Styles/TextBox.xaml" />
    </ResourceDictionary.MergedDictionaries>

</ResourceDictionary>

grafik

This way I can not reproduce the problem you are having. Please reinstall EverythingToolbar and try to do it like this.

After reinstalling and exchanging the theme folder name in the above system environment, the problem remains, and this time there is no need to modify the height of the text box, just right-click on the rounded part to reproduce.

I will create a new Windows 10 virtual machine to try it out.


Windows 10 virtual machines cannot reproduce, this is most likely a problem with StartAllBack.