search

srwiley / rasterx

Rasterx is an SVG 2.0 path compliant rasterizer that can use either scany, the golang vector or a derivative of the freetype anti-aliaser.
BSD 3-Clause "New" or "Revised" License
133 stars 11 forks source link

I tried adding rasterx to awesome-go page... needs some work before they will accept it #5

Open rcoreilly opened 6 years ago

rcoreilly commented 6 years ago

I was adding GoGi etc to it and figured I'd add rasterx while I was at it.. Anyway, looks like you'll have to do some things and submit it separately if you want to:

https://github.com/avelino/awesome-go/pull/2222

These should be improved, they have a lot of issues, especially with golint: https://goreportcard.com/report/github.com/srwiley/rasterx

These miss a lot of documentation, which should also be improved: https://godoc.org/github.com/srwiley/rasterx

these don't have enough coverage: https://github.com/srwiley/rasterx

srwiley commented 6 years ago

Thanks i will look into it. Documentation is supposed to be there for every public function and variable, so sure, I could do more there. I tend to error on the side of making everything public, and let the users decided at what level they want to use things, although I know that can add to confusion. As for coverage, a lot of the testing of rasterx is done by the oksvg package, so maybe submitting then together would fix the coverage problem, or maybe moving or duplicating some tests. OK, thanks for the heads up.

On Tue, Nov 20, 2018 at 10:48 PM rcoreilly notifications@github.com wrote:

I was adding GoGi etc to it and figured I'd add rasterx while I was at it.. Anyway, looks like you'll have to do some things and submit it separately if you want to:

avelino/awesome-go#2222 https://github.com/avelino/awesome-go/pull/2222

These should be improved, they have a lot of issues, especially with golint: https://goreportcard.com/report/github.com/srwiley/rasterx

These miss a lot of documentation, which should also be improved: https://godoc.org/github.com/srwiley/rasterx

these don't have enough coverage: https://github.com/srwiley/rasterx

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/srwiley/rasterx/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ALlXBxoSXOB80BGMEU9yNUwua7uaLXW9ks5uxPc5gaJpZM4Ysgbb .