search

ssafty / terasoft-12

Educational Kinect Game using C# and XNA
https://www.youtube.com/watch?v=sl8d_kQj3c0
0 stars 0 forks source link

Story No : 4.04 As a user, I can have a randomly generated game which is solvable and follows the rules of physics regarding the projectile motion #21

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
As a user, I can have a randomly generated game which is solvable and follows 
the rules of physics regarding the projectile motion

Tasks : 

    1)story sequence diagram & artifact.
        2)Implementation of getSolvablePoints().
        3)Implementation of helper methods.
        4)documentation of methods.

Original issue reported on code.google.com by hollaxy...@gmail.com on 13 Apr 2012 at 4:44

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 17 Apr 2012 at 11:51

GoogleCodeExporter commented 9 years ago 
Done.

Original comment by hollaxy...@gmail.com on 20 Apr 2012 at 5:38

GoogleCodeExporter commented 9 years ago 
Missunderstood what Status Done mean.Changed back to In-Progress.

Original comment by hollaxy...@gmail.com on 23 Apr 2012 at 12:09

GoogleCodeExporter commented 9 years ago 
For the Documentation, please follow the following order: Author, Parameter, 
Summary, Return

Original comment by mohamedra2fat on 24 Apr 2012 at 10:23

GoogleCodeExporter commented 9 years ago 
Tamer, the convention of the Documentation will be as follows, Authod, 
Summmary, Parameter, Return

Original comment by mohamedra2fat on 24 Apr 2012 at 10:38

GoogleCodeExporter commented 9 years ago 
Tamer, you a method called getSolvablePoints that takes an input , but in the 
documentation you haven't stated that it takes parameter.

Original comment by mohamedra2fat on 25 Apr 2012 at 9:37

GoogleCodeExporter commented 9 years ago 
getRandomAngle method. -> No Return Value in the documentation
getRandomVelocity method. -> No Return Value in the documentation
Double getX.-> Parameter 'caseH' doesn't exist in the method, and it is stated 
in the documentation.
Double checkPositive.-> no return in the documentation

Original comment by mohamedra2fat on 25 Apr 2012 at 11:20

GoogleCodeExporter commented 9 years ago 
Return value is always /// <returns></returns>   not more than that.  

Fixed other things.

Original comment by hollaxy...@gmail.com on 25 Apr 2012 at 12:51

GoogleCodeExporter commented 9 years ago 
No. Return is not like that. If there is something to be returned, then it 
should be written

Original comment by mohamedra2fat on 25 Apr 2012 at 3:30

GoogleCodeExporter commented 9 years ago 
- Diagram name not written!
- Stereo types are not used!
- Who is calling getSolvablePoints()
- missing calls !!
- will Review again after these points are fixed

Original comment by mohamed....@gmail.com on 25 Apr 2012 at 3:32

GoogleCodeExporter commented 9 years ago 
@raafat : you mistaked in changing the label ,you changed implementation not 
documentation.Anyways it is fixed now

Original comment by hollaxy...@gmail.com on 25 Apr 2012 at 4:07

GoogleCodeExporter commented 9 years ago 
Summary would be before Author. Summary, Author, Parameter, Return. 
I know that I told you before another conventions

Original comment by mohamedra2fat on 25 Apr 2012 at 5:52

GoogleCodeExporter commented 9 years ago 
1) many instance variables are not needed, helper variables should be declared 
in methods not as instance variables
2) many extra variables are declared and there is no need for it, for example 
(TimeNeeded, TimeNeeded2, angleInDegree, TimeSlice2, RandomTimeForPrey,..) 
decrease the number of variables so the code could be readable
3) the method rand.Next shouldn't be used as it's only applicable on int, 
should implement another one suitable for doubles and floats
4) use Vector2 instead of splitting X and Y coordinates in 2 separate variables
5) putting "90" as an accepted angle, is illogical
6) convert all methods and variables to private, only Prey, Predator, Aquarium, 
Tolerance, Angle, Velocity getters in addition to the constructor should be 
public

Original comment by 3abdelazim on 25 Apr 2012 at 6:17

GoogleCodeExporter commented 9 years ago 
@zaza and @raafat your comments are done. please recheck :)

Original comment by hollaxy...@gmail.com on 25 Apr 2012 at 8:00

GoogleCodeExporter commented 9 years ago 
Documentation verified

Original comment by mohamedra2fat on 25 Apr 2012 at 8:11

GoogleCodeExporter commented 9 years ago 
1) make a getter method to tolerance
2) instead of PPret, PPredator, Paquarium, name them preyLocation, 
predatorLocation,..
3) velocity should be represented as double not int
4) values of velocity ranges should be synchronized with Raafat late on
5) GetSolvablePoints doesn't need to get tolerance as a parameter, it should 
use the instance variable.

Original comment by 3abdelazim on 25 Apr 2012 at 8:19

GoogleCodeExporter commented 9 years ago 
@zaza ,your comments were taken into consideration and it is done now.

Original comment by hollaxy...@gmail.com on 25 Apr 2012 at 8:47

GoogleCodeExporter commented 9 years ago 
teksab m3aaana :D

Original comment by 3abdelazim on 25 Apr 2012 at 8:50

GoogleCodeExporter commented 9 years ago 
@Zayat : umls are done,please recheck :)

Original comment by hollaxy...@gmail.com on 25 Apr 2012 at 11:40

GoogleCodeExporter commented 9 years ago 
Thank you Tamer :)

Original comment by mohamed....@gmail.com on 27 Apr 2012 at 1:51

GoogleCodeExporter commented 9 years ago 
Sorry wrong comment (it was for 0.11) !
will review this story now isA
sorry for inconvenience

Original comment by mohamed....@gmail.com on 27 Apr 2012 at 1:53

GoogleCodeExporter commented 9 years ago 
No actor Activation Box is required(just a note)

Original comment by mohamed....@gmail.com on 27 Apr 2012 at 3:20

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r756.

Status: In Progress

UpOn Tamer's Request All wrong int's were changed to float

Original comment by mohamed....@gmail.com on 27 Apr 2012 at 9:06

GoogleCodeExporter commented 9 years ago 
Please change the things about return tag

Original comment by mohamedra2fat on 27 Apr 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
Fixed

Original comment by hollaxy...@gmail.com on 27 Apr 2012 at 9:51

GoogleCodeExporter commented 9 years ago

Original comment by mohamedra2fat on 27 Apr 2012 at 9:52

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 14 May 2012 at 8:49

GoogleCodeExporter commented 9 years ago 
Documentation-Ready

Original comment by hollaxy...@gmail.com on 15 May 2012 at 6:27

GoogleCodeExporter commented 9 years ago 
firstly, use smart commits
secondly, when ready, change the implementation status

Original comment by 3abdelazim on 17 May 2012 at 12:55

GoogleCodeExporter commented 9 years ago 
i did not say implementation ready bro.i did not finish it yet.

about smart commits : i use smart commits.However what you mean is linking 
between issue number and issue itself and ok i will do it.

Original comment by hollaxy...@gmail.com on 17 May 2012 at 1:08

GoogleCodeExporter commented 9 years ago 
If you are using smart commits correctly, you commits should be visible here in 
the issue

Original comment by 3abdelazim on 17 May 2012 at 1:35

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 17 May 2012 at 8:55

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1085.

Added another constructor to be used for graphs,assured no clonflicts in width 
of prey and aquarium

Original comment by hollaxy...@gmail.com on 17 May 2012 at 10:13

GoogleCodeExporter commented 9 years ago 
UML : https://docs.google.com/file/d/0B-dUQ-lqzETwbGp6bnhKNEJsbEE/edit

Original comment by hollaxy...@gmail.com on 18 May 2012 at 2:35

GoogleCodeExporter commented 9 years ago 
well. It's a big code so I will review it on several times
firstly : don't use underscores, and don't use 'var' (I will explain to you why 
later)
secondly : use += instead of x = x +
thirdly : no line should exceed 120 char. split any line that exceeds that limit

Original comment by 3abdelazim on 21 May 2012 at 12:27

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1278.

fixed names to follow conventions + adding gravity and tolerance as constants

Update issue 244
Status : In-progress
fixing code according to zaza review

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:14

GoogleCodeExporter commented 9 years ago 
fixing uml

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:25

GoogleCodeExporter commented 9 years ago 
will edit some lines

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:43

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1285.

splitting lines greater than 120

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:51

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 21 May 2012 at 6:53

GoogleCodeExporter commented 9 years ago 
uml : https://docs.google.com/file/d/0B-dUQ-lqzETwLW5RbkpCUVJFSXM/edit

Original comment by hollaxy...@gmail.com on 21 May 2012 at 7:23

GoogleCodeExporter commented 9 years ago 
Discovered bugs in it,trying to know why they happened.

Original comment by hollaxy...@gmail.com on 21 May 2012 at 11:14

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1307.

Added some constraints to try to avoid bug appears 1 time in every 100 game.

Original comment by hollaxy...@gmail.com on 22 May 2012 at 12:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1337.

Fixed bugs of giving NaN and zero values + fixing conflicts between objects

Original comment by hollaxy...@gmail.com on 22 May 2012 at 9:37

GoogleCodeExporter commented 9 years ago 
Fixing uml  to follow the changes.

Original comment by hollaxy...@gmail.com on 22 May 2012 at 9:39

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1568.

Added Tests for solvable points

Original comment by hollaxy...@gmail.com on 24 May 2012 at 1:50

GoogleCodeExporter commented 9 years ago 
uml : https://docs.google.com/file/d/0B-dUQ-lqzETwV054MmF0WGZPNmc/edit?pli=1

Original comment by hollaxy...@gmail.com on 24 May 2012 at 2:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1812.

Added constructor zaza wants.

Original comment by hollaxy...@gmail.com on 25 May 2012 at 12:22

GoogleCodeExporter commented 9 years ago

Original comment by 3abdelazim on 25 May 2012 at 1:01