search

ssafty / terasoft-12

Educational Kinect Game using C# and XNA
https://www.youtube.com/watch?v=sl8d_kQj3c0
0 stars 0 forks source link

208: As a user i should see a ball coming towards me from a random direction #226

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Documentation
Sequence Diagram
Implementation I: redesign class Ball
Implementation II: animte the ball movement

Original issue reported on code.google.com by bishoyba...@gmail.com on 11 May 2012 at 11:07

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r972.

Status: In Progress

edited Experiment3 classes namespace

Original comment by bishoyba...@gmail.com on 17 May 2012 at 9:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1008.

Status: In Progress

added method Rotate to Ball class

Original comment by bishoyba...@gmail.com on 17 May 2012 at 12:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1009.

Status: In Progress

added BallAnimation class and edited Experiment3 and Simulation to use it

Original comment by bishoyba...@gmail.com on 17 May 2012 at 12:55

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1012.

Status: In Progress

moved the ball.Rotate() from Experiment3 and Simulation classes call to 
BallAnimation

Original comment by bishoyba...@gmail.com on 17 May 2012 at 1:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1171.

Status: In Progress

call motion methods LinearMotion class instead of Functions class

Original comment by bishoyba...@gmail.com on 19 May 2012 at 8:36

GoogleCodeExporter commented 9 years ago 
why am I not cc'ed?

Original comment by khaled.osmaan on 20 May 2012 at 3:49

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1237.

Status: In Progress

added GenerateIntialPosition method to class ball
removed dummy variables from Experiment3
added empty constructor to Environment3

Original comment by bishoyba...@gmail.com on 20 May 2012 at 9:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1283.

Status: In Progress

changed constructor to take Hole hole

Original comment by bishoyba...@gmail.com on 21 May 2012 at 6:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1284.

Status: In Progress

edited update method

Original comment by bishoyba...@gmail.com on 21 May 2012 at 6:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1288.

Status: In Progress

added methods documentation

Original comment by bishoyba...@gmail.com on 21 May 2012 at 7:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1289.

Status: In Progress

added Experiment3 class documentation

Original comment by bishoyba...@gmail.com on 21 May 2012 at 7:45

GoogleCodeExporter commented 9 years ago

Original comment by bishoyba...@gmail.com on 22 May 2012 at 8:36

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1331.

Status: In Progress

edited ball intial position and Experiment3 camera

Original comment by bishoyba...@gmail.com on 22 May 2012 at 8:23

GoogleCodeExporter commented 9 years ago

Original comment by bishoyba...@gmail.com on 23 May 2012 at 8:05

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1379.

Status: In Progress

edited class constructor

Original comment by bishoyba...@gmail.com on 23 May 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1380.

Status: In Progress

edited LoadContent method

Original comment by bishoyba...@gmail.com on 23 May 2012 at 9:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1382.

Status: In Progress

edited LoadContent method

Original comment by bishoyba...@gmail.com on 23 May 2012 at 9:52

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1410.

Status: In Progress

edited CustomModel constructor calls

Original comment by bishoyba...@gmail.com on 23 May 2012 at 11:20

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1432.

Status: In Progress

edited ball stoping conditions and added buttons if user missed to shoot

Original comment by bishoyba...@gmail.com on 23 May 2012 at 1:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1439.

Status: In Progress

added method InsideTerrain and edited GenerateIntialPosition

Original comment by bishoyba...@gmail.com on 23 May 2012 at 2:19

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1441.

Status: In Progress

edited GenerateIntialPosition in ball and edited Update in Experiment3

Original comment by bishoyba...@gmail.com on 23 May 2012 at 2:43

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1444.

Status: In Progress

edited GenerateIntialPosition in ball and edited Update in Experiment3

Original comment by bishoyba...@gmail.com on 23 May 2012 at 2:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1446.

Status: In Progress

edited GenerateIntialPosition in ball and edited Update in Experiment3

Original comment by bishoyba...@gmail.com on 23 May 2012 at 3:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1461.

Status: In Progress

changed HasFinished to Finished and edited

Original comment by bishoyba...@gmail.com on 23 May 2012 at 4:09

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1462.

Status: In Progress

added documentation

Original comment by bishoyba...@gmail.com on 23 May 2012 at 4:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1463.

Status: In Progress

edited Draw in Experiment3 and added InitializeButtons method

Original comment by bishoyba...@gmail.com on 23 May 2012 at 4:13

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1466.

Status: In Progress

edited Draw method

Original comment by bishoyba...@gmail.com on 23 May 2012 at 4:29

GoogleCodeExporter commented 9 years ago 
Class Simulation

"represents the simulation of the result"
Capitalize and add a '.'

"Auther : Bishoy Bassem"
spelling mistake and per our company's conventions it should be AUTHOR: 

"constructs a new Simulation instance and intializes it"
Capitalize and add a '.' and shouldn't it be creates instead of constructs?

 /// <param name="shootPosition">shoot position vector</param>
/// <param name="holePosition">hole position vector</param>
/// <param name="shootVelocity">shoot velocity vector</param>
/// <param name="friction">friction magnitude</param>
/// <param name="content">content manager</param>
/// <param name="device">draphics device</param>
/// <param name="spriteBatch">sprite batch</param>
Not descriptive at all. None of them are even sentences. The description of 
spritebatch is sprite batch? How is that considered a description? It is simply 
stating the obvious, and spelling mistake in "draphics". Please make them more 
descriptive, and be sure to capitalize the start of each sentence and add a '.' 
at the end.

/// <summary>
/// updates the chase camera and model's position and orientation according to 
the time elapsed
/// </summary>
/// <param name="gameTime"></param>

Capitalize and add a '.' & it is rather ambiguous. Does it update the 
orientation and position of the chase camera and the model, or does it update 
the chase camera and updates the position and orientation of the model? please 
make it more clear. Also where is the description of game time? You can simply 
use XNA's default description of it.

"draws the velocity values"
Capitalize and add a '.' & how do you draw velocity values?  If you mean to 
display the values of the velocity on the screen (which you probably do), 
please specify this and make it more clear

the method public bool Finished() lacks documentation.

All methods are lacking the AUTHOR: tag except the constructor, please add them.

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:43

GoogleCodeExporter commented 9 years ago 
Class ball

"represents the ball type"
Capitalize and add a '.' and how is ball a type? type of what?

"constructs a new ball instance"
Capitalize and add a '.'

/// <param name="radius">ball radius</param>
/// <param name="device">graphics device</param>
/// <param name="content">content manager</param>
Once again stating the obvious. How would anyone gain anything by reading this?

"sets the ball orientation according to the moving direction"
Capitalize and add a '.' and it should be "the direction the ball is moving in" 
or something like that... needs to be more descriptive

<param name="displacement">displacement vector</param>
stating the obvious again.

/// <summary>
        /// sets the ball height
        /// </summary>
        /// <param name="height">height</param>
Capitalize and add a '.' & "the ball's height" & stating the obvious in "height"

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:53

GoogleCodeExporter commented 9 years ago 
Forgot to reopen

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:54

GoogleCodeExporter commented 9 years ago 
Class BallAnimation
"constructs a new BallAnimation instance "
Creates instead of constructs? Also capitalize and add a '.'

<param name="ball">ball</param>
        /// <param name="hole">hole</param>
        /// <param name="velocity">intial velocity vector</param>
        /// <param name="friction">friction magnitude</param>
Stop stating the obvious

public override void Update(TimeSpan elapsed) has no documentation

Change all Author tags in all of your classes to AUTHOR to follow the company's 
conventions

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:56

GoogleCodeExporter commented 9 years ago 
Class Experiment 3
"constructs a new Experiment3 screen"
Creates and capitalize and add a '.'

<param name="user">user</param>
Be descriptive and don't state the obvious

"loads the experiment's content"
Capitalize and add a '.'

"updates the experiment's screen"
Capitalize and add a '.'

<param name="gameTime">GameTime instance</param>
Be descriptive and don't state the obvious

"draws the experiment's screen"
Capitalize and add a '.'

<param name="gameTime">GameTime instance</param>
Be descriptive and don't state the obvious

and once again AUTHOR not Author.

Original comment by ams.sa...@gmail.com on 23 May 2012 at 4:59

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1612.

Status: In Progress

updated documentation 
splited Update method in class Experiment3 to UpdateFirstAnimation, 
UpdateSecondAnimation
edited ball InsideTerrain and GenerateIntialPosition methods

Original comment by bishoyba...@gmail.com on 24 May 2012 at 7:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1613.

Status: In Progress

removed GraphicsDevice from ball constructor
and changed Experiment3 accordingly

Original comment by bishoyba...@gmail.com on 24 May 2012 at 7:31

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1614.

Status: In Progress

updated classes documentation

Original comment by bishoyba...@gmail.com on 24 May 2012 at 7:49

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1615.

Status: In Progress

updated classes documentation

Original comment by bishoyba...@gmail.com on 24 May 2012 at 7:50

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1616.

Status: In Progress

edited buttons position

Original comment by bishoyba...@gmail.com on 24 May 2012 at 8:00

GoogleCodeExporter commented 9 years ago 
*Make sure that the lines don't exceed 120, please !!!!
*Deleted unused GraphicsDevice variables.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 8:02

GoogleCodeExporter commented 9 years ago

Original comment by bishoyba...@gmail.com on 24 May 2012 at 8:54

GoogleCodeExporter commented 9 years ago 
>>class Ball:
InsideTerrain(): group the variables between the operators. please !!!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 11:02

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1655.

Status: In Progress

edited curly braces in InsideTerrain method

Original comment by bishoyba...@gmail.com on 24 May 2012 at 11:30

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 11:32

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1656.

Status: In Progress

edited typos and used Environment3 new width and height properties

Original comment by bishoyba...@gmail.com on 24 May 2012 at 11:44

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1673.

Status: In Progress

edited button sizes and positions

Original comment by bishoyba...@gmail.com on 24 May 2012 at 1:12

GoogleCodeExporter commented 9 years ago 
The constructor of class Ball shouldn't take the content manager !!! change it 
to take the model which you load from the environment !!!

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 2:30

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1681.

Status: In Progress

changed Ball constructor to accept Model not ContentManager
and changed Experiment3 LoadContent accordingly

Original comment by bishoyba...@gmail.com on 24 May 2012 at 2:43

GoogleCodeExporter commented 9 years ago

Original comment by bishoyba...@gmail.com on 24 May 2012 at 2:44

GoogleCodeExporter commented 9 years ago

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 2:59

GoogleCodeExporter commented 9 years ago 
compile error at UpdateFirstAnimation(GameTime gameTime)

Original comment by khaled.osmaan on 24 May 2012 at 3:49

GoogleCodeExporter commented 9 years ago 
>>class CustomModel:
*I've asked you 2 times to make the braces of the constructor to be in a new 
line, please fix it !!!
*Create a new method called Initialize() that takes the model. and delete the 
model from the constructor.

Original comment by ahmedheg...@gmail.com on 24 May 2012 at 4:04