search

ssafty / terasoft-12

Educational Kinect Game using C# and XNA
https://www.youtube.com/watch?v=sl8d_kQj3c0
0 stars 0 forks source link

205: As a user i must be able to see a window before the experiment starts containing the instructions #36

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The user will see a window containing the instructions for the experiment

Original issue reported on code.google.com by khaled.osmaan on 13 Apr 2012 at 7:10

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 13 Apr 2012 at 7:12

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 21 Apr 2012 at 4:51

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r304.

Message: implemented method draw which draws the new how to play screen related 
to experiment 3 and added its documentation

Original comment by khaled.osmaan on 22 Apr 2012 at 10:03

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 22 Apr 2012 at 10:24

GoogleCodeExporter commented 9 years ago 
Vector2 position = new Vector2(100, 20);
Instruction I = new Instruction("The goal of this game is to shoot the ball 
such that it reaches the hole with 0 velocity", position);

replace the left hand types with var, obvious types.

Original comment by q3a...@gmail.com on 23 Apr 2012 at 10:28

GoogleCodeExporter commented 9 years ago 
Instruction I = new Instruction("The goal of this game is to shoot the ball 
such that it reaches the hole with 0 velocity", position);

line too long, break it to 2-3 lines

Original comment by q3a...@gmail.com on 23 Apr 2012 at 10:29

GoogleCodeExporter commented 9 years ago 
using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Audio;
using Microsoft.Xna.Framework.Content;
using Microsoft.Xna.Framework.GamerServices;
using Microsoft.Xna.Framework.Graphics;
using Microsoft.Xna.Framework.Input;
using Microsoft.Xna.Framework.Media;

Do you actually need all those imports? i'm sure you don't use half of those 
imports

Original comment by q3a...@gmail.com on 23 Apr 2012 at 10:49

GoogleCodeExporter commented 9 years ago 
@ comment5 : currently changing types to var
@ comment6 : line can not be broken into 2-3 lines since I'm passing the string 
I want to show in the screen as a parameter where the constructor in class 
Instruction with deal with it, will define the line as a string and pass it to 
the constructor instead
@ comment7 : I needed the imports to use the type "Vector2" I wasn't sure in 
which package it was though, now since I'll be using type var I don't think 
I'll use them anymore

Original comment by khaled.osmaan on 23 Apr 2012 at 11:14

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r317.

Message: removed unused imports, changed obvious variable types to var, split a 
long line into two as requested by reviewer

Original comment by khaled.osmaan on 23 Apr 2012 at 11:43

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 23 Apr 2012 at 11:51

GoogleCodeExporter commented 9 years ago 
you still need to use the package for Vector2!! and as for the packages, u have 
to look for the package you need and remove the rest.

As for the long line u can put the string on a seperate line and the other 
parameters after the string in another line as well

Original comment by q3a...@gmail.com on 23 Apr 2012 at 12:54

GoogleCodeExporter commented 9 years ago 
and as for the new implementation for writting the string and saving it in a 
variable
string instructions = "The goal of this game is to shoot the ball such that it 
reaches the hole with 0 velocity";

again use var and not string

Original comment by q3a...@gmail.com on 23 Apr 2012 at 12:56

GoogleCodeExporter commented 9 years ago 
comment11 fixed in last commit
comment12 will do it later tonight along with committing my work on another 
issue

Original comment by khaled.osmaan on 23 Apr 2012 at 1:31

GoogleCodeExporter commented 9 years ago 
better have separate small commits, remember that small commits are
preferred to large one

Original comment by q3a...@gmail.com on 23 Apr 2012 at 1:53

GoogleCodeExporter commented 9 years ago 
better have separate small commits, remember that small commits are preferred 
to large one

Original comment by q3a...@gmail.com on 23 Apr 2012 at 1:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r322.

Message: changed variable instructions from type string to var as requested by 
reviewer

Original comment by khaled.osmaan on 23 Apr 2012 at 2:34

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 23 Apr 2012 at 3:27

GoogleCodeExporter commented 9 years ago 
Microsoft.Xna.Framework.GameTime
use GameTime directly because the class is already using Microsoft.Xna.Framework

Original comment by q3a...@gmail.com on 23 Apr 2012 at 3:35

GoogleCodeExporter commented 9 years ago 
doesn't really matter -.-..

Original comment by khaled.osmaan on 23 Apr 2012 at 3:38

GoogleCodeExporter commented 9 years ago 
yes, but it looks ugly and makes the import useless(in case it was used only 
for GameTime), and should be changed wa2ela mesh ha2fel el issue :P

Original comment by q3a...@gmail.com on 23 Apr 2012 at 3:49

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r328.

commented a couple of lines after commenting class Instruction due to some 
errors in class Instructions, currently fixing...

Original comment by khaled.osmaan on 23 Apr 2012 at 4:12

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r334.

Message: uncommented the lines, errors fixed

Original comment by khaled.osmaan on 23 Apr 2012 at 5:06

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r336.

Message: uncommented class and fixed errors.

Original comment by khaled.osmaan on 23 Apr 2012 at 5:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r344.

Punctuated the documentation as requested by reviewer

Original comment by khaled.osmaan on 23 Apr 2012 at 6:14

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 23 Apr 2012 at 6:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r359.

status InProgress
removed unused imports

Original comment by khaled.osmaan on 23 Apr 2012 at 8:25

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r380.

status inProgress
changed line I.Draw() to I.Draw2()

Original comment by khaled.osmaan on 23 Apr 2012 at 10:06

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r393.

status inProgress
replaced Draw2() with Draw() when calling after removing method Draw2 from 
class Instruction

Original comment by khaled.osmaan on 24 Apr 2012 at 10:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r419.

status inProgress
Let the class extend class Instruction and use its base (super) methods, 
implementation might need to be reviewed again

Original comment by khaled.osmaan on 24 Apr 2012 at 1:53

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 24 Apr 2012 at 1:58

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r444.

status inProgress
removed unused import which made an error as a result of a team member's change 
in class Instruction

Original comment by khaled.osmaan on 24 Apr 2012 at 9:30

GoogleCodeExporter commented 9 years ago 
1.Microsoft.Xna.Framework.GameTime, use GameTime directly

2.Don't override a virtual empty method with another empty method, doesn't make 
any sense, right>

Original comment by q3a...@gmail.com on 25 Apr 2012 at 9:37

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r466.

status inProgress
fixed documentation, edited empty constructor, replaced 
Microsoft.Xna.Framework.GameTime with GameTime, removed empty method.

Original comment by khaled.osmaan on 25 Apr 2012 at 11:52

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 25 Apr 2012 at 11:57

GoogleCodeExporter commented 9 years ago 
Same as comment 31 in issue 32. Some text came off of the screen.

Original comment by ams.sa...@gmail.com on 25 Apr 2012 at 10:34

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r552.

status inProgress
made class extend GameScreen instead of Instruction , edited LoadContent and 
Update methods

Original comment by khaled.osmaan on 26 Apr 2012 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 26 Apr 2012 at 2:03

GoogleCodeExporter commented 9 years ago 
design not updated with latest implementation, doesn't show interaction between 
other classes needed to draw/update the screen.

Original comment by khaled.osmaan on 26 Apr 2012 at 9:28

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by khaled.osmaan on 27 Apr 2012 at 1:03

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r663.

status inProgress
added documentation for method Remove()

Original comment by khaled.osmaan on 27 Apr 2012 at 1:29

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Apr 2012 at 3:11

GoogleCodeExporter commented 9 years ago 
Change order of the tags to this, to follow conventions:
1- summary
2- remarks (author)
3- parameters
4-return
of course any of them that doesn't exist is not written as usual.

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 5:12

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r718.

status inProgress
fixed documentation as requested by reviewer

Original comment by khaled.osmaan on 27 Apr 2012 at 5:30

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Apr 2012 at 5:35

GoogleCodeExporter commented 9 years ago 
1. Some lines are long

2. Some Methods are overriden, while you only call the base method, useless

Original comment by q3a...@gmail.com on 27 Apr 2012 at 6:50

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r738.

broke long lines into two, made class variables private, deleted useless 
override in method Remove()

Original comment by khaled.osmaan on 27 Apr 2012 at 7:01

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Apr 2012 at 7:01

GoogleCodeExporter commented 9 years ago 
Works as it should when tested with text made so that won't go out of the 
screen. Was told to do this by Ghoroury.

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 9:28

GoogleCodeExporter commented 9 years ago 
        /// Allows the game screen to run logic such as updating the world,
        /// checking for collisions, gathering input, and playing audio.
        /// and detects if the user clicked the button to skip this screen

There is a "." in the middle of the sentence and none at the end.

Original comment by ams.sa...@gmail.com on 27 Apr 2012 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 12 May 2012 at 9:43