search

ssalonen / cec-rs

GNU General Public License v2.0
10 stars 8 forks source link

Added log_message_callback #12

Closed coral closed 2 years ago

coral commented 2 years ago

I added support for the log_message_callback in order to easier write code for applications that monitor the feed rather than acts as a remote.

I tried to keep it relatively similar to what was already in the repo (great Rust btw, learned some new tricks from this repo). I did run the tests, ran clippy and rustfmt. Hope it's decent enough.

Sidenote: Thanks a lot for taking the time to write this wrapper in Rust, very much appreciate it.

ssalonen commented 2 years ago

Hi @coral

Thank you for the contribution! Overall looks good, but I will review closer at a later date.

Can you please rebase to get the CI fixes to this branch as well? It should help with the build errors.

coral commented 2 years ago

@ssalonen Implemented the suggested changes and hopefully I managed to rebase (or at least I think so, not a git expert).

Feel free to squash all my commits when merging as well.