Fix calling `libcec_close` twice on drop

ssalonen / cec-rs

GNU General Public License v2.0

10 stars 8 forks source link

Closed kira-bruneau closed 1 month ago

kira-bruneau commented 2 months ago

The libcec_close call in CecConnection::drop is unnecessary because libcec_destroy already calls libcec_close: https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/LibCECC.cpp#L53-L61

ssalonen commented 2 months ago

Lint seems to be breaking with old untouched code. Not related to this PR - just new rules...

kira-bruneau commented 2 months ago

Ok! I just created a new PR for that here: https://github.com/ssalonen/cec-rs/pull/50. I can rebase the other PRs once that is in to make it easier to review.