ssalonen / libcec-sys

FFI bindings for the libcec
GNU General Public License v2.0
2 stars 3 forks source link

Compilation fails #5

Closed ssalonen closed 2 years ago

ssalonen commented 2 years ago

Bug description

libcec-sys compilation seems to fail, as indicated in downstream library https://github.com/ssalonen/cec-rs/pull/12

It seems that --parallel flag is not accepted by the cmake version used in the cross build.

In cmake 3.12, the --parallel flag was introduced. It looks like cmake crate (which is used in build.rs) started to use this new flag in https://github.com/alexcrichton/cmake-rs/pull/123.

The error is probably due to too old cmake version.

Indeed, builds use docker images based on cross 0.1.16, which uses cmake 3.5.1 https://github.com/rust-embedded/cross/blob/v0.1.16/docker/cmake.sh#L4

To Reproduce

Expected behavior

Screenshots

Environment

Additional context

coral commented 2 years ago

Can confirm that I ran into this when trying to build libcec-sys locally and assumed it was my machine but seems to be general.

ssalonen commented 2 years ago

thanks @coral. I will try to see if updating the docker images would help.

ssalonen commented 2 years ago

Hopefully resolved via https://github.com/ssalonen/libcec-sys/pull/6

We can close this issue once downstream library build succeeds.