fix: Fix issue 118 - Githubissues

ssandrews / Smoldyn

Smoldyn is a particle-based biochemical simulator for modeling molecular diffusion, surface interactions, and chemical reactions

GNU General Public License v3.0

24 stars 13 forks source link

fix: Fix issue 118 #119

Closed dilawar closed 2 years ago

dilawar commented 2 years ago

This PR fixes #118 and

Update pybind11 to latest version (2.9.1)
Fixed regression caused by https://github.com/ssandrews/Smoldyn/commit/f8e18de9bf1cf99d714fa8191792caeecfb6f890. Number of slices must be at the end of the list of floats passed to C API.

dilawar commented 2 years ago

Disk requires argument slices.


s = smoldyn.Simulation(
    low=[-1000, -1000, -10000], high=[1000, 1000, 10000], output_files=["cylinder.txt"]
)

d1 = s.addDisk(name="d1", center=[50, 25, 8500], radius=850, vector=[0, 0, -1], slices=10)
test = s.addSurface("test", panels=[d1])