search

ssannandeji / Zenject-2019

Dependency Injection Framework for Unity3D
MIT License
2.53k stars 366 forks source link

Enhancement: Make ZenjectBinding extendable #364

Open JLeybovich opened 6 years ago

JLeybovich commented 6 years ago

We have a need to extend ZenjectBinding to provide an Identifier that is not a string (regular object). Would it be possible to change ZenjectBinding.Identifier from string to object and have the getters marked as virtual? The end goal is to use Types instead of strings to be more secure which seems doable based on that Id can be any object.

Thanks,

svermeulen commented 6 years ago

Yeah that change makes sense to me. I'd be happy to merge a pull request like that.