Open adarapata opened 5 years ago
Hi. The explanation about ByNewPrefabResourceInstaller seemed not to be appropriate, so I fixed it. Because ByNewPrefabResourceInstaller has to inherit InstallerBase, it should be a class that inherited Installer, not MonoInstaller.
ByNewPrefabResourceInstaller
InstallerBase
Installer
MonoInstaller
refs test code https://github.com/modesttree/Zenject/blob/8ad1c8c11eb328ab625438d4cc05c505e6be9fdd/UnityProject/Assets/Plugins/Zenject/OptionalExtras/IntegrationTests/Tests/Bindings/TestFromPrefabInstaller/TestFromPrefabInstaller.cs#L50-L61
https://github.com/modesttree/Zenject/blob/8ad1c8c11eb328ab625438d4cc05c505e6be9fdd/UnityProject/Assets/Plugins/Zenject/OptionalExtras/IntegrationTests/Tests/Bindings/TestFromPrefabInstaller/TestFromPrefabInstaller.cs#L91-L97
Sorry if it is not wrong.
You're right, thanks. I've cherry picked this in extenject with commit 8bfdf0eb
Hi. The explanation about
ByNewPrefabResourceInstaller
seemed not to be appropriate, so I fixed it. BecauseByNewPrefabResourceInstaller
has to inheritInstallerBase
, it should be a class that inheritedInstaller
, notMonoInstaller
.refs test code https://github.com/modesttree/Zenject/blob/8ad1c8c11eb328ab625438d4cc05c505e6be9fdd/UnityProject/Assets/Plugins/Zenject/OptionalExtras/IntegrationTests/Tests/Bindings/TestFromPrefabInstaller/TestFromPrefabInstaller.cs#L50-L61
https://github.com/modesttree/Zenject/blob/8ad1c8c11eb328ab625438d4cc05c505e6be9fdd/UnityProject/Assets/Plugins/Zenject/OptionalExtras/IntegrationTests/Tests/Bindings/TestFromPrefabInstaller/TestFromPrefabInstaller.cs#L91-L97
Sorry if it is not wrong.