search

ssanthosh243 / semicomplete

Automatically exported from code.google.com/p/semicomplete
0 stars 0 forks source link

Building xdotool on Mac OS X #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
xdotool's Makefile has some Linux-isms hardcoded into it which make it not
work on Mac OS X. When I added xdotool to MacPorts a few days ago, I had to
patch the Makefile, mostly to fix the name of the shared library and the
way in which it is created. The Makefile makes libraries libxdo.so and
libxdo.so.$(MAJOR), but on Mac OS X the naming convention is to use
libxdo.dylib and libxdo.$(MAJOR).dylib. In addition I had to replace
"-shared" with "-dynamiclib" and replace "-Wl,-soname=libxdo.so.$(MAJOR)"
with "-Wl,-install_name,$(INSTALLLIB)/libxdo.$(MAJOR).dylib".

The attached patch is what I put in MacPorts. It's clearly not appropriate
for inclusion in the official xdotool source as-is since it unconditionally
uses Mac OS X's methods. But it would be great if you could include a
conditionalized version, which would use Mac OS X's methods when `uname` is
"Darwin" and the existing methods otherwise.

What version of the product are you using? On what operating system?
xdotool 1.20100318.2737 on Mac OS X 10.6.3

Original issue reported on code.google.com by ryandesi...@gmail.com on 15 Apr 2010 at 11:19

Attachments:

GoogleCodeExporter commented 9 years ago 
I've updated the makefile to support this, I think. I'll put together a new 
release 
tonight.

Original comment by jls.semi...@gmail.com on 16 Apr 2010 at 12:17

GoogleCodeExporter commented 9 years ago 
http://semicomplete.googlecode.com/files/xdotool-1.20100415.2808.tar.gz

Original comment by jls.semi...@gmail.com on 16 Apr 2010 at 4:25

GoogleCodeExporter commented 9 years ago 
Works great, thanks. Quickest bugfix ever! :)

Original comment by ryandesi...@gmail.com on 16 Apr 2010 at 7:16

GoogleCodeExporter commented 9 years ago 
Oops, no it doesn't. Moment...

Original comment by ryandesi...@gmail.com on 16 Apr 2010 at 7:22

GoogleCodeExporter commented 9 years ago 
Here's the remaining patch that should fix it.

Original comment by ryandesi...@gmail.com on 16 Apr 2010 at 7:27

Attachments:

GoogleCodeExporter commented 9 years ago 
Oops. Good catch.

Original comment by jls.semi...@gmail.com on 16 Apr 2010 at 7:38

GoogleCodeExporter commented 9 years ago 
http://semicomplete.googlecode.com/files/xdotool-1.20100416.2809.tar.gz

Original comment by jls.semi...@gmail.com on 16 Apr 2010 at 7:59

GoogleCodeExporter commented 9 years ago 
Thanks, that does work.

Original comment by ryandesi...@gmail.com on 22 Apr 2010 at 8:59

GoogleCodeExporter commented 9 years ago 
Sweet. Thanks for reporting this and also for doing the macports maintenance :)

Original comment by jls.semi...@gmail.com on 22 Apr 2010 at 9:19