Flakey tests

[GoogleCodeExporter]

Ran the tests for a few hours and tracked all failures.

Here's the breakdown, sorted by number of failures:
      1 test_getwindowfocus_gets_a_valid_window(XdotoolBasicTests)
      6 test_search_pid(XdotoolSearchTests) [./test_search.rb:12]:
     17 test_search_title(XdotoolSearchTests) [./test_search.rb:19]:
     19 test_misc(XdotoolBasicTests)
     79 test_getwindowfocus_gets_a_valid_window(XdotoolBasicTests) 
[./test_basic.rb:21]:
    149 test_search_onlyvisible_with_pid(XdotoolSearchTests) 
[./test_search.rb:42]:
    201 test_search_onlyvisible_with_pid(XdotoolSearchTests) 
[./test_search.rb:26]:
    217 test_windowsize_by_pixel_works(XdotoolBasicTests) 
[./test_basic.rb:49]:
    221 test_windowmove(XdotoolBasicTests) [./test_basic.rb:96]:
    277 test_windowsize_by_size_hints(XdotoolBasicTests) 
[./test_basic.rb:63]:
    314 test_windowfocus(XdotoolBasicTests)
    361 test_windowmapping(XdotoolBasicTests) [./test_basic.rb:112]:

Original issue reported on code.google.com by jls.semi...@gmail.com on 9 May 2010 at 6:40

[GoogleCodeExporter]

Original comment by jls.semi...@gmail.com on 9 May 2010 at 6:43

Attachments:

• FAILURES

[GoogleCodeExporter]

svn r2859 (and others) should resolve this.

I've been running the following for an hour with no test failures:
% while make test-xvfb-openbox ; do done

There may still be other tests that are flakey. I'm still digging.

Original comment by jls.semi...@gmail.com on 13 May 2010 at 8:59

[GoogleCodeExporter]

I think I've fixed all of the major test flakiness.

All of the fixes were done by changing how we run the tests rather than making 
changes 
to xdotool given the scenario and situations.

It's possible some of the behavior exhibited by the new test methods should be 
included in xdotool (like adding a 'synchronous' or 'blocking' flag to each 
command 
that only returns when a command has completed). This is for later, though.

Original comment by jls.semi...@gmail.com on 14 May 2010 at 7:28

• Changed state: Fixed