search

ssantichaivekin / empress

Systematic Cophylogeny Reconciliation Tool under Duplication-Transfer-Loss Model.
https://sites.google.com/g.hmc.edu/empress/
15 stars 6 forks source link

[PART 2] GUI: Fix old clusters do not get replaced bug #219

Closed ssantichaivekin closed 4 years ago

ssantichaivekin commented 4 years ago

Fixes two bugs in #182

  1. Incorrect number of clusters calculated after changing the cost.

This is because the code assumes that the input box of the cluster window always has 1 as its starting value. However, this is not always the case since if we change the cost and click on the cluster window again, the current behavior is that the box will have value as what the box has last time it is used.

self.validate_num_cluster_input(1)  # old
self.validate_num_cluster_input(self.num_cluster_entry_box.get())  # new
  1. View reconciliations -> One per cluster is not disabled properly, it can display old information.

Fixed by disabling the dropdown option when we change the cost and re-enabling them when we click on Enter button.

Resolve #182

ssantichaivekin commented 4 years ago

PS. You could review (and approve) this pull request even when the base branch is not master.