0.9.9 sdist doesnt contain test data file 20-00-cnf.sh

ssato / python-anyconfig

Python library provides common APIs to load and dump configuration files in various formats

MIT License

277 stars 31 forks source link

Closed jayvdb closed 5 years ago

jayvdb commented 5 years ago

Running the tests from the sdist results in

error: [Errno 2] No such file or directory: '/home/abuild/rpmbuild/BUILD/anyconfig-0.9.9/tests/res/20-00-cnf.sh'

> grep -r 20-00-cnf.sh
anyconfig-0.9.9/tests/backend/shellvars.py:    cnf_s = TBC.read_from_res("20-00-cnf.sh")

ssato commented 5 years ago

Thanks a lot for your report! Good catch.

Some other files are not contained in sdist also and this packaging bug should be fixed with the commit 52c2d0c3, I think.

jayvdb commented 5 years ago

I find using https://pypi.org/project/check-manifest/ with exceptions listed in setup.cfg a good way to catch these.

jayvdb commented 5 years ago

I did an RPM build of master, and check passes on Python 2.7, 3.4, 3.6 and 3.7