Make logging behave - Githubissues

ssato / python-anyconfig

Python library provides common APIs to load and dump configuration files in various formats

MIT License

279 stars 31 forks source link

Make logging behave #12

Closed wbolster closed 9 years ago

wbolster commented 9 years ago

This PR removes all custom logging magic, and changes the behaviour to the standard way of logging for Python libraries.

In short, instead of magic global loggers and setting global configuration (so that applications experience problems), all logging calls are simply emitted on module-level loggers. It's up to the application to route these messages somewhere useful by configuring handlers and setting levels.

Fixes #11.

landscape-bot commented 9 years ago

Repository health decreased by 0.22% when pulling 88a7f69 on wbolster:make-logging-behave-properly into 64ea3bd on ssato:master.

2 new problems were found (including 0 errors and 2 code smells).
No problems were fixed.

coveralls commented 9 years ago

Coverage decreased (-0.97%) to 94.42% when pulling 88a7f69bbe793971ab7ed7bcbe65d3e46046087a on wbolster:make-logging-behave-properly into 64ea3bd660e67318eea2762e4723d3f2d952cc0d on ssato:master.

ssato commented 9 years ago

Thanks a lot for the fix. You're right. Merged as it is.

wbolster commented 9 years ago

Great @ssato. Any chance you could publish a new release with this fix? Thanks!

ssato commented 9 years ago

I've just released the new version that fix was included. Please let me know if you any issues w/ it. And, again, thanks for the fix!

wbolster commented 9 years ago

Awesome, thanks @ssato.