search

ssato / python-anyconfig

Python library provides common APIs to load and dump configuration files in various formats
MIT License
278 stars 31 forks source link

Make load function template arguments boolean #126

Closed Terrance closed 3 years ago

Terrance commented 3 years ago

The documentation describes the ac_template parameter as boolean, but the underlying load() function tests for ac_template is not None, meaning False is ignored and files are always parsed as templates.

This updates the check to a truthy one, along with making the type annotations and default arguments match the documented API.

ssato commented 3 years ago

Thanks a lot! You're absolutely right. I'll look at it in detail and merge your PR later. So please wait for a while.

Terrance commented 3 years ago

Any chance we can get a new release with this fix in? 🙂

ssato commented 3 years ago

Sorry to late response. I've just released the 0.11.1 contains this fix.