ssb22 / jianpu-ly

Jianpu in Lilypond
http://ssb22.user.srcf.net/mwrhome/jianpu-ly.html
Apache License 2.0
70 stars 18 forks source link

Repeat broken (my bad) #39

Closed suntong closed 1 year ago

suntong commented 1 year ago

Originally posted by @ssb22 in https://github.com/ssb22/jianpu-ly/issues/23#issuecomment-1500613842

I also like the idea of the pipe | character, which can be used to represent a bar line separating two measures of music, which can be made optional, and ignored by the compiler, and serve no purpose apart from making the score more readable (and help parsing when note crosses barline cases occurs)

yes it's doable but ...

When suggesting that ignored pipe | character, I forgot about its usage within repeat. IE now repeat is broken. Please think of ways to fix the situation. The ways I can think of are:

Any ways you can think of works for me, as it was my bad introducing the bug.

Thanks

ssb22 commented 1 year ago

Well spotted, thanks. I moved the code around so | is an (undocumented) barline check only if we're not in an A{ block