ssbc / bendy-butt-spec

6 stars 0 forks source link

make bad vectors #10

Closed cryptix closed 2 years ago

cryptix commented 3 years ago

We only have a happy path vector file. To make it easier for implementations to harden their verification rules we should also make some with broken/invalid messages.

These might include:

I'd also wager it's better to have these as a seperate file to keep the "good" vector file less complicated.

arj03 commented 3 years ago

Looks like a good list. Maybe also add message length. And I agree that it would be good with a separate file :)

mycognosist commented 3 years ago

To make it easier for implementations to harden their verification rules we should also make some with broken/invalid messages

Very good idea. Agree with @arj03 on the message length suggestion. Maybe also some incorrect content examples, assuming you wish to include broken content validation and not just message validation? So that might include incorrect type for content (maybe a string instead of the expected array of dictionary), unsupported type value (metafeed/anomaly), nonce not base64 encoded etc.