search

ssbc / bendy-butt-spec

6 stars 0 forks source link

decouple definitions from metafeeds #16

Closed staltz closed 3 years ago

staltz commented 3 years ago

This is a change to the spec which aims at making bendy butt useful for people who would like to use it for purposes other than meta feeds. Other highly related PRs are: https://github.com/ssb-ngi-pointer/ssb-bendy-butt/pull/20 and https://github.com/ssb-ngi-pointer/ssb-meta-feed-spec/pull/16

There are some important changes and some cosmetic changes.

The important ones are:

Cosmetic changes:

arj03 commented 3 years ago

Overall this looks quite good. Great that you improved the examples. I have some specific things I'll comment on directly in the diff.

arj03 commented 3 years ago

end of review :)

staltz commented 3 years ago

I'll do the updates tomorrow :)

staltz commented 3 years ago

Updated, I'm still on the outlook for more feedback. :eyes: