search

ssbc / bendy-butt-spec

6 stars 0 forks source link

first review comments #2

Closed cryptix closed 3 years ago

cryptix commented 3 years ago
  1. define sequence as varint (the one we already use in bipf, i'd say)
  2. define that previous for seq:0 is an empty message tfk (so zero bytes instead of nothing)
  3. i'd move timestamp inside message content, if possible
  4. content is encoded as bipf, too, i guess?
  5. signature and content signature? why?
arj03 commented 3 years ago

This is great feedback!

1. define sequence as varint (the one we already use in bipf, i'd say)

I was referrering to this:

INT : 2 // little endian 32 bit integer

I'll make that a bit clearer

2. define that previous for seq:0 is an _empty message tfk_ (so zero bytes instead of nothing)

Good idea, thanks!

3. i'd move timestamp inside  message content, if possible

I'd rather leave it here to make it easier for clients as that matches closer with classic SSB format.

4. content is encoded as bipf, too, i guess?

Yes, clarified that a bit

5. signature and content signature? why?

That was not very clear maybe. 1 signature for sub feed and 1 signature for meta feed. I have defined what fields MUST be in content, that should maybe make things a bit clearer I hope :)

cryptix commented 3 years ago

:+1:

Resolved after our call and the recent commits. :)