ssbc / bipf

Binary json codec optimized for in-place access
MIT License
48 stars 9 forks source link

improve test coverage up to 94.5% #20

Closed staltz closed 2 years ago

staltz commented 2 years ago

Achieves 100% code coverage except for seekKey2 (which I'm not sure what we should do about it, seems like it's not used).

arj03 commented 2 years ago

As for seekkey2, considering that this module is only used in ssb I think it is safe to remove that function. Proper version and all, but in general I'm in favor of removing code that is not used.

staltz commented 2 years ago

Thanks!

Yep, I can remove seekKey2 in another PR