search

ssbc / chloride

MIT License
90 stars 17 forks source link

Upgrade sodium-native #16

Closed christianbundy closed 4 years ago

christianbundy commented 4 years ago

Problem: sodium-native has released a new major version and it's great to stay up-to-date with our upstream dependencies.

Solution: Upgrade it. It seems that the breaking change is "Removed object instance apis and replaced them with init, update, final methods", but that doesn't seem to apply to us (?) as npm test continues to pass without problems.

clehner commented 4 years ago

+1 This will also add Node v12 and v14 support (https://github.com/dominictarr/chloride/issues/14). It will also result in smaller downloads, as sodium-native v3.2.0 is 3.1 MB, compared to sodium-native v2.4.9 at 13 MB.

christianbundy commented 4 years ago

I think we should probably fork this to SSBC like we did with dominictarr/obv -> ssbc/obz.

christianbundy commented 4 years ago

Alright, what are we naming this bad boy? I'm going with Flouride unless someone suggests something else.

clehner commented 4 years ago

@christianbundy Dominic has now added the chloride module to the ssbc team on npmjs.com

arj03 commented 4 years ago

Nice, just ran into this. LGTM! :)

clehner commented 4 years ago

Published https://github.com/ssbc/chloride/releases/tag/v2.3.0

arj03 commented 4 years ago

Thank you @clehner!