search

ssbc / chloride

MIT License
90 stars 17 forks source link

Tests not currently passing #26

Open KyleMaas opened 3 years ago

KyleMaas commented 3 years ago

Was trying to hunt down an issue and found that chloride's tests are not currently passing in the main branch.

staltz commented 3 years ago

How so? This is the latest commit on main: https://github.com/ssb-js/chloride/runs/1611479946

KyleMaas commented 3 years ago

test-results-redacted.txt

Maybe I'm reading the output wrong, but I'm seeing a lot of "expected throw: Error: (something)" where in other tests it says PASSED. I would think the absence of PASSED and the presence of Error would indicate a problem. Here are the results I'm seeing, with working directory redacted.

christianbundy commented 3 years ago

My memory: That's normal. This package doesn't use a normal test runner, see my comment in #22 .

KyleMaas commented 3 years ago

Hm. That's unfortunate. Not at all clear.

christianbundy commented 3 years ago

Yep. It's fixed in #21 fwiw.