search

ssbc / go-ssb

Go implementation of ssb (work in progress!)
https://scuttlebutt.nz
160 stars 26 forks source link

Allow for configuration of both go-sbot and sbotcli #327

Closed KyleMaas closed 1 year ago

KyleMaas commented 1 year ago

See #151

Not quite done yet, but making progress.

KyleMaas commented 1 year ago

@decentral1se I think this is pretty well ready to go. I haven't done much testing other than the automated test suite, though, so if you could look this over carefully please that'd be great.

Only thing I don't like about it is that it doesn't autodetect the previous style of configuration file and just deal with it - instead it complains until you update the format of your existing files. I mean, the project's still technically in "alpha", but I don't like the breaking change aspect of it. However I'm not really sure how to do that elegantly with the way the config file is currently being parsed.

KyleMaas commented 1 year ago

@decentral1se Thanks for taking a look!

Re: warning - yes, that means no configuration is being picked up. I can change that.

Re: Presence - yes, since it's its own module now, presence needed to be changed to Presence so that it could be accessed from outside of the module. I can try and figure out where that's persisted from and take that out of the export.

KyleMaas commented 1 year ago

@decentral1se How's that look?

KyleMaas commented 1 year ago

Awesome. Thanks!