cryptix
commented
3 years ago @arj03 found a bug ( https://github.com/ssbc/epidemic-broadcast-trees/pull/42 ) where a peer received a message, confirmed it but then looses it somehow.
It's a great test case (dealing with misbehaving remote peers correctly). Reproducing this right now would require stopping the go-ssb peer, truncating the log, re-indexing and then connecting again.
"reboot" tests are on the table anyhow to check the state matrix persistence worked as intended.
It would be really good to cover more of the unchecked tests in https://github.com/cryptoscope/ssb/pull/72#issuecomment-765297854
but mostly I'd love to see this stuff:
[ ] Update the vector clock / want list not just once after connecting Currently the sets of feeds we want to receive is just send once when the connection is established. The JS documentation is a bit lacking about when to actually re-send those and thus confirm received messages. But also it doesn't send a clock update once we call sbot.Replicate(feed) - which means reception is delayed until a reconnect... at least this a part should be fixed before merging this.
[ ] Implement a more scalable solution to canceling individual feed subscriptions Right now there is a context per feed. This works but is inefficient. Probably need to re-work the multisink so that they can be unsubscribed directly.
[ ] Partition sets of feeds over multiple connections One of the advantages of ebt, other then not asking about feeds that didn't change, is receiving feeds from the best known source. For this we need a bit of heuristics, like ping to the peer and who has messages sooner.
Preliminary testing results: functional but a couple of glitches.
[ ] rebuilding of the own/self network frontier after changes on the replication lister (graph walk) The TODO above about this acknowledged a slight variation of this but it's actually worse. Right now, it just builds the network frontier for ebt when it doesn't have one.. any (un)follows after the first ebt connection are without effect.
[ ] Followgraph walk finishes to soon Tangential and slightly sure it was the case before these changes. The graph/builder walk along the follow messages sometimes collapses and returns to few results.
[x] Untangle circular dependency between state matrix and graph builder (See PR #97) Before the graph builder was hooked up after the indexing system. The way it's setup now, the combined index needs the state matrix to update it with new received messages... which also needs the graph now for the first fill. This circle needs to be broken so that the server setup doesn't race.