search

ssbc / multiserver

A single interface that can work with multiple protocols, and multiple transforms of those protocols (eg, security layer)
MIT License
104 stars 28 forks source link

add test for unix-socket plugin #34

Closed cryptix closed 4 years ago

cryptix commented 5 years ago

I noticed there were no tests for this plugin so I added at least this one. also verifies @arj03 comment on the linked issue, that the server:true option is needed.

(updates ssbc/scuttlebot#577)

cryptix commented 5 years ago

currently based on #35 but could be untangled.

cryptix commented 5 years ago

https://ci.appveyor.com/project/cryptix/multiserver/builds/20982608/job/6bvvas7ifkvymhu8#L100

windows can listen but not connect, it seems. need to refresh my assumptions. still think this should be fixable.

cryptix commented 5 years ago

this issue looks like i need to do that chmod.. but that also gave me a ENOENT error... hmmmmm.. I'll get a windows VM later.

christianbundy commented 5 years ago

@cryptix

Is this still good to go, or does it need something else before review?

cryptix commented 5 years ago

@christianbundy I think it's good to go but I didn't touch this since opening it. I fear I forgot all about why it acted up on windows. Still think it should be doable to run all this on the three platforms.

dominictarr commented 5 years ago

@cryptix I had to rebase this, but merged. thanks! sorry it lingered this long.

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

christianbundy commented 4 years ago

Closing because it was already rebased onto master.