search

ssbc / multiserver

A single interface that can work with multiple protocols, and multiple transforms of those protocols (eg, security layer)
MIT License
104 stars 28 forks source link

Upgrade tape to 5.0.1, fix tests #60

Closed christianbundy closed 4 years ago

christianbundy commented 4 years ago

We have an outdated version of Tape that allows tests to call t.end() multiple times, which we're apparently doing.

This commit upgrades tape and puts the t.end() inside of the close() callback so that it's run after close instead of at random times (in the middle of other tests).

arj03 commented 4 years ago

Hmm travis is not happy? Then again, it wasn't happy before. The changes looks good. This includes a lock file as well, see my comment in other PR ;-)

christianbundy commented 4 years ago

Travis isn't happy on Node 8 or MacOS -- not sure what the problem is on MacOS, but from the logs it looked like a WS thing. I'm trying to see if I can fix that right now, but it should be unrelated to this PR.

christianbundy commented 4 years ago

This includes a lock file as well, see my comment in other PR ;-)

Oh, oops. Didn't see that you wrote this.

arj03 commented 4 years ago

This is a very nice change. Great catch!

arj03 commented 4 years ago

Also would probably be good with a release of master sometime soon I think. Probably before the ws change, as to not put in more stuff.