search

ssbc / patchbay

An alternative Secure Scuttlebutt client interface that is fully compatible with Patchwork
http://www.scuttlebutt.nz
386 stars 78 forks source link

fix device scope #317

Closed dominictarr closed 5 years ago

dominictarr commented 5 years ago

local/private scope is the local network, i.e. wifi. not localhost. that is the device scope.

A unix socket can only be connected to within the device.

This will fix https://github.com/ssbc/ssb-server/issues/640

I'm not really happy with the scope names. It seems like a confusion as to meaning of the names lead to this bug..

I'd kinda lead towards "device" "nearby" "global" or something. get away from networking terms?

dominictarr commented 5 years ago

also, appologies for using github edit to make the PR. I had just enough time to do that.

christianbundy commented 5 years ago

Oops, looks like I forgot to PR cd91f627f4e517409efe0ca1fd453bd9947b65f9.

Merging!