search

ssbc / patchbay

An alternative Secure Scuttlebutt client interface that is fully compatible with Patchwork
http://www.scuttlebutt.nz
386 stars 78 forks source link

Use ssb-lan instead of ssb-local for better privacy #356

Closed arj03 closed 4 years ago

arj03 commented 5 years ago

This uses ssb-lan.

I noticed that ssb-ahoy also includes ssb-local in ./lib/build-plugins.js, so that probably also needs updating?

Tested IRL with @Powersource and @cblgh

staltz commented 5 years ago

Nice that you're also going to use ssb-lan! If this is for "better privacy", note that currently ssb-lan emits both the legacy style (hence compatible with other peers still using ssb-local) as well as the new style. Using the legacy style means we have no privacy, so basically ssb-lan will only provide privacy once we stop using the legacy mode. If you want, we could add an option in ssb-lan to disable legacy broadcast, but this comes with the cost that we won't discover other peers using ssb-local (e.g. Patchwork users).

Also, could this PR be done at the same time as ssb-conn is used in Patchbay? This way you wouldn't have to add any new code in app/sync/initialise/, just .use(require('ssb-lan')) and ssb-conn will handle the discoveries for you.

arj03 commented 5 years ago

Hah, I just came to the same conclusion about ssb-conn as you can see in the other issue :)

And yeah, I'm thinking of rolling this in with legacy still enabled and once patchwork is updated we can disable it I think.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

staltz commented 4 years ago

Stop bot

arj03 commented 4 years ago

This is no longer relevant as latest master includes ssb-lan