search

ssbc / patchbay

An alternative Secure Scuttlebutt client interface that is fully compatible with Patchwork
http://www.scuttlebutt.nz
386 stars 78 forks source link

Styling is a bit weird, text hard to read #360

Closed Powersource closed 4 years ago

Powersource commented 4 years ago

Running latest master. I don't think it's looked like this before but I'm getting some deja vu. No custom styles.

image

christianbundy commented 4 years ago

It's the emoji font! I've had this since the noto color emoji font was added. Happy to chat more about this if you'd like, we had to fix it in Patchwork.

Powersource commented 4 years ago

Sure, would be nice to fix. How was it fixed in patchwork?

christianbundy commented 4 years ago

Instead of setting a font-family: NotoColorEmoji on all text we do:

.emoji {
  font-family: NotoColorEmoji;
}

Then you just pass an emoji property to ssb-markdown with a function like:

https://github.com/ssbc/patchwork/blob/c76136fb1628ec7fd4bb10b181d70ced01bb120c/lib/depject/message/html/markdown.js#L49-L57

(You can ignore the emojiMentions[emoji] condition, that's for Patchwork's "custom emoji" functionality that I've never actually seen working.)

Powersource commented 4 years ago

Remember that we need to update patchcore in patchbay before it works

Powersource commented 4 years ago

Can't get patchbay to build atm but I think this issue still applies since patchcore hasn't had a new release.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?