search

ssbc / patchcore

A shared library of depject modules to build Secure Scuttlebutt social network apps
GNU Affero General Public License v3.0
74 stars 17 forks source link

don't include replies in threads or rollups from people blocked by root message author #65

Closed mmckegg closed 6 years ago

mmckegg commented 6 years ago

This is something that came up a while back in discussions about moderation (%kYS6xrmtePS0zFcZVNjd+TyDSahMwlnCYPXs3ksfsqM=.sha256).

The PR adds a check when rolling up replies and building threads to ensure that replies are only included if the author of the root message does not block the author of the reply.

It still includes replies to the blocked message, and the blocked message will still be directly viewable, but at least it removes it out of the main thread!

I'll probably be merging this soon, just creating this PR so that others know about this important patchcore change!

cc @mixmix

mixmix commented 6 years ago

Cool. I'm rolling my own rollup for the moment but appreciate being looped in to this

On Sun, 8 Jul 2018, 15:08 Matt McKegg, notifications@github.com wrote:

Merged #65 https://github.com/ssbc/patchcore/pull/65.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssbc/patchcore/pull/65#event-1721691621, or mute the thread https://github.com/notifications/unsubscribe-auth/ACitnq752AnWXxP_-SOQ0mOGTYFBDoUgks5uEXeqgaJpZM4VGkbJ .

arj03 commented 6 years ago

@mmckegg I ran into this today in the mainsplaining thread: %2xPphCmdVcK7I6c3c78Q5tJUEstlRzjpfXAIRcSlOcQ=.sha256. It was actually quite confusing that I couldn't see the messages from kas, as he is blocked by dan. This is in patchbay mind you, maybe the missing messages are better displayed in patchwork.

How about it works this way, unless I follow the person that is blocked? Or even better, that we are friends?

mmckegg commented 6 years ago

@arj03

Yeah, maybe. But I think it should at least display a warning. What I'm trying to avoid is stuff happening inside of a person's thread that they can't see themselves.

In patchwork it says "In reply to ....." for messages that are out of sequence or missing, so it is still pretty easy to find them if someone has replied.

arj03 commented 6 years ago

I see. That makes a lot more sense now. I really applaud you for working on this problem as it is very tricky with a lot of cases. I like the idea with a warning, that way you can see why they are missing and educate at the same time.

Thanks 💚