search

ssbc / patchcore

A shared library of depject modules to build Secure Scuttlebutt social network apps
GNU Affero General Public License v3.0
74 stars 17 forks source link

Use new path at `msg.value.meta.private` #73

Closed christianbundy closed 4 years ago

christianbundy commented 6 years ago

Older versions of secure-scuttlebutt set metadata about the unboxer at msg.value.private, but the new version sets that in msg.value.meta.private to isolate metadata from the rest of the message. This commit will only work with secure-scuttlebutt 18.6.0 and higher -- do we have a way to specify that dependency?

See: https://github.com/ssbc/secure-scuttlebutt/pull/228#issuecomment-435438060

cc: @mmckegg @mixmix

christianbundy commented 6 years ago

Should we add Scuttlebot as a peer dependency to make sure we're using the correct version? I'm sure this isn't the only thing that requires a specific version of Scuttlebot.

mixmix commented 6 years ago

Yeah true. This is gonna break some stuff. Need to search code bases for private

Not sure on ideal solution. Do you mean list in the readme a min version of sbot

On Fri, 30 Nov 2018, 07:40 Christian Bundy, notifications@github.com wrote:

Should we add Scuttlebot as a peer dependency to make sure we're using the correct version? I'm sure this isn't the only thing that requires a specific version of Scuttlebot.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssbc/patchcore/pull/73#issuecomment-442945728, or mute the thread https://github.com/notifications/unsubscribe-auth/ACitnikpW0dFXo7Eeag2OokPJcjGs9i9ks5u0Co2gaJpZM4YPLtu .

christianbundy commented 5 years ago

Sorry @mixmix, I meant to add it as a peerDependency, so npm jumps out and says "hey this only works with scuttlebot@13.1.0" or whatever. Alternatively, maybe at this point we could just say that it requires ssb-server, since that happened in 13.3.0.