search

ssbc / patchcore

A shared library of depject modules to build Secure Scuttlebutt social network apps
GNU Affero General Public License v3.0
74 stars 17 forks source link

Missing pull-pause #81

Closed m4gpi closed 5 years ago

m4gpi commented 5 years ago

Trying to use patchcore in dark-crystal-standalone and it seems pull-pause is no longer listed as a dependency.

Error: Cannot find module 'pull-pause'
    at Module._resolveFilename (module.js:543:15)
    at Function.Module._resolveFilename (/home/kyphae/Projects/dark-crystal-standalone/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:473:25)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/kyphae/Projects/dark-crystal-standalone/node_modules/patchcore/lib/pullLookup.js:4:17)
    at Object.<anonymous> (/home/kyphae/Projects/dark-crystal-standalone/node_modules/patchcore/lib/pullLookup.js:45:3)
    at Module._compile (module.js:642:30)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32)

I've added it back in as a dependency, but I'm not sure what the decision was re: why this was removed. Anyway, opened a PR here: https://github.com/ssbc/patchcore/pull/82

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?