some messages not displaying in some contexts

[masukomi]

in my main mentions view at the bottom of this thread %U7lzR/HbIKyXaa5pTWYRZW5inHC6kMKH2OsLECjT084=.sha256

i see this

note that there are no replies to it.

if i click into the post by richard %ZouzPNEduEmP/umSyoJTrZnlVRQGC+3x+hnmYPwdxa8=.sha256

i see this

note that there is 1 response to it (or the thread)

if i go back and use the reply button in the 1st image i see this

note that there are now 2 responses and one of them is mine.

I started this discovery because i was thinking "what?!?! I thought i responded to that." i had, but in 2 out of 3 contexts i can't see my own response.

[mmckegg]

@masukomi

The mentions feed isn't supposed to show your replies, just replies that mention you, so I think that first case is fine.

The second one is working correctly because it is only showing direct replies to %ZouzPNEduEmP/umSyoJTrZnlVRQGC+3x+hnmYPwdxa8=.sha256. Your reply was to the second message in that view and can be seen if you click on its "3 days ago" (%mujXZJwKrqDT4NEUddR3n76kBvWIjjnqUgHG98AjD3M=.sha256).

I'm assuming the third case is viewing the entire thread, where you should be seeing all messages that reference that first root.

I'll admit this is pretty confusing, but as far as I can see from your screenshots, it is working as intended.

[masukomi]

I hear what you're saying, but this is just... yeah "confusing"

Personally I don't expect the mentions feed to be hiding parts of the thread. I expect it to be highlighting parts of the thread.

The second one makes logical sense, but it doesn't make sense in the context of the current UI because the current UI isn't threaded. When i look at the full thing i see 2 posts below Richard's and both are at the same level.

proposed solutions to minimize confusion

(obviously any decision to implement these should go in new tickets)

mentions feed

This should never make it look like other posts don't exist in the thread. This is confusing for two reasons. In my case when you've already replied to it and it makes it look like you haven't done so. The other case is that the post mentioning you is in reference to another person's post above it that is now hidden and you've lost the context of the mentioning statement.

Instead mentions should emphasize the post that mentions you. This can be either a literal highlight (color change) or it could be to somehow minimize the other posts. something like making them one line blocks that say "reply to X by y" with something you could click to expand to see the full thing, or go to the thread in the default view

displaying subthreads

We need to pick a single thread representational model.

We can't have one unthreaded UI which tells you "hey this is all one discussion" while clicking a link to a specific post in that thread only shows you it and its direct replies.

Either patchwork is displaying a linear timestream of replies OR it's a threaded discussion. In the current model you're going to have many people hitting reply to the initial thread, when they should be replying to a reply (or to a reply to a reply) in what has become a subthread. Currently you've got a lot of folks breaking the "correct" reply chain / subthreads in what Patchwork thinks of as a threaded discussion because they can't see the threads, and it looks like a linear stream, and thus just reply in the big box at the bottom that's encouraging them to type in it.