Bug po box vector - Githubissues

ssbc / private-group-spec

GNU Lesser General Public License v3.0

13 stars 2 forks source link

Bug po box vector #15

Closed mixmix closed 2 years ago

mixmix commented 2 years ago

I found a bug!

this test vector for po-box encryption was not a the right BFE type.

What I've done:

wrote a test to catch incorrect BFE type-format for keys
fixed the test vector
- generated the test vector output using ssb-pirvate-group-keys module code

mixmix commented 2 years ago

Recommend this is a Semver Patch version release

arj03 commented 2 years ago

Funny coincidence you are opening a fix against this, I was looking at this spec and BFE spec recently and was wondering where exactly these "3 encryption formats" are used. Can you help me better understand that?

mixmix commented 2 years ago

They're used in box2 dms / pobox. Keys that go into deriving a shared key are bfe encoded for the "info" part of some of it Keep in mind bwe don't use ed25519 keys, we use curve25519. So we choose which sort of key it is dm or pobox.

Can give you more specificity when at computer if needed. Or look in ssb-private-group-keys to see dm / pobox stuff.

I'm about to open a pr there to fix/ extend some things I need for ssb-keys. Also found a gotcha over there...