ssbc / private-group-spec

GNU Lesser General Public License v3.0
13 stars 2 forks source link

Add Member: duplicate initialMsg field? #2

Closed cryptix closed 4 years ago

cryptix commented 4 years ago

Shouldn't initialMsg be equal to the root of the group and members tangles? Or even remove it?

mixmix commented 4 years ago

it should be a duplication of tangles.group.root, yes

Have fixed this and left a note in : b0b24a028508ce77681b629dad1dc9188bc20fae

Considerations:

mixmix commented 4 years ago

I think this resolves this issue @cryptix , I've closed it. If you think it's not a good solution feel free to reopen and can discuss more.

Really appreciate your close reading!

cryptix commented 4 years ago

it doesn't cost much here

I’m leaning on the side of why have an extra key that you could set wrong but I can live with it if we clearly spec that these three keys need to be equal.