update the spec for group/add-member to be v2!

ssbc / private-group-spec

GNU Lesser General Public License v3.0

13 stars 2 forks source link

update the spec for group/add-member to be v2! #23

Closed mixmix closed 1 year ago

mixmix commented 1 year ago

We have a required change to the format of the group/add-member message:

the feedId in recps MUST be the root feed, which is format bendybutt!
the version needs to be bumped (this is not the v1 schema any more!)

If we're making breaking changes lets change groupKey to secret

Look at us, version out specs!

:fire: this PR will require us to do some changes to schema in this spec. Will wait for other PRs to settle down. We may also need to keep both version of the spec, i.e. v1 and v2, as if there are json files being pulled in by Ahau for migration

Powersource commented 1 year ago

Also yeah maybe different conversation but how will ahau do things? Stay on v1 and have 1.1, 1.2 etc?

mixmix commented 1 year ago

@Powersource ready for review!!!

Changes made:

stored an old version of the v1 group/add-member schema (Ahau will need v1 + v2)
modified the group/add-member schema
- added a creator field (in case the person receiving the add-member doesn't replicate the group creator yet, which is needed)
- ~~changed groupKey > secret (I like this term more now... why not... future mix will hate me I'm sure)~~
all specs - changes the FeedId definition to be bendybutt-v1 (this is the only id used in recps now)

mixmix commented 1 year ago

decided to undo the groupKey to secret change. I wish it was secret, but it will just cause a cascade of code changes elsewhere which is silly

Powersource commented 1 year ago

@mixmix let's get this merged and published :) would be nice to have addMember verification back in tribes2

Powersource commented 1 year ago

@mixmix boop

mixmix commented 1 year ago

Pubished as v3.0.0