Closed pietgeursen closed 6 years ago
Hey @mixmix,
Keen to get your thoughts on the shape of the returned poll observable.
It's not the same shape as the decorated poll object that poll.async.get
returns which I'm not very happy about. What do you reckon? Is it good enough if we just document it well?
looking at this now
This is a bit of a rambly review sorry. I enjoyed reading over it and it had me thinking about what good pull / mutant patterns are from readability and performance might be. Forgive me for thinking out loud, the quantity I wrote is about me not being sure.
I tried to flag the important points with red : :fire:
@mixmix Ok, I'm pretty happy with this. And also ready to just do something different. I've been on this one PR for ages so keen to get momentum back.
Do you want to cast your eye over it?
pollDoc
so that is matches the one that you get with async.get
. Although the actions are missing off this one I just realised.