extract config, and add working config from patchbay

ssbc / scuttle-shell

A system tray app for running Secure Scuttlebutt and providing sbot features to your local system

54 stars 10 forks source link

extract config, and add working config from patchbay #24

Open mixmix opened 5 years ago

mixmix commented 5 years ago

scuttle-shell wasn't quite working for me. When I went to investigate, I noticed the config was a bit odd compared to patchbay. I'm still getting my head around this connections config stuff.

But I've found using this branch in patchbay everything works happily (that I've seen so far!)

In this PR:

[x] extraction of config building into ./config.js
[ ] :fire: dropping minimist in config building because ssb-config uses RC, which I think does everything we want for loading config?! this needs attention
[x] copies in connections config which works in patchbay

mixmix commented 5 years ago

I see one of these socket errors (where previously I'd see 5+), but patchbay seems to run fine

err? { Error: connect ECONNREFUSED /home/mixmix/.ssb/socket
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)
  code: 'ECONNREFUSED',
  errno: 'ECONNREFUSED',
  syscall: 'connect',
  address: '/home/mixmix/.ssb/socket' }

cryptix commented 5 years ago

Sorry that I can’t add anything here. The RC vs JSON config is black magic that always confused me... mostly just that we have two config file systems to begin with.

Re the socket error is fine as long as it works in the end. The Client tries to redial until it works. The fluctuation you see should just be difference in sbot boot time before it can accept connections.

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

christianbundy commented 4 years ago

Anything I can do to help with this? Not sure if scuttle-shell is still active, but noticed this PR was still open.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?