ssbc / scuttle-shell

A system tray app for running Secure Scuttlebutt and providing sbot features to your local system
54 stars 10 forks source link

node-systray dependency installs their own binaries #4

Closed cryptix closed 6 years ago

cryptix commented 6 years ago

Are there alternatives to that particular module? It crams some helpers into the system in a manner that i find strange. IMHO it stretches the role of npm to what the package managment of the system should be in charge of... I wrote more about it here: %Vx/1OSDLnXXu4P3Cmo4Mq8ZTO2kRRpT32o9JAUoFG8o=.sha256

cryptix commented 6 years ago

at the very least, I don't understand why it doesn't put them in node_modules/.bin

cryptix commented 6 years ago

i should also make a PR or issue at least on zaaack/node-systray so that it complains nicley to install the helper by hand. (edit: posted as zaaack/node-systray#7)

I just fear that this approach will lead to problems when bundling big apps into appImages, etc.

cryptix commented 6 years ago

I think it's okay to close this. We agreed to make a fork to solve this:

See https://github.com/ssbc/node-systray