Closed staltz closed 4 years ago
Beautiful! I have notifications on for some repos, but if you need reviews on stuff please feel free to @mention me or request one directly.
Oh, just noticed that you did request a review from me. Keep doing that! :laughing:
Love it
On Thu, 2 Jul 2020, 05:14 Christian Bundy, notifications@github.com wrote:
Oh, just noticed that you did request a review from me. Keep doing that! 😆
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ssbc/secret-stack/pull/53#issuecomment-652544654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUK3HRWPF6XZGK3XPB54VLRZNVH7ANCNFSM4OMBQFHQ .
I'm gonna be sending some pull requests to this repo with the goal of "solidifying it" (removing its hacky proof of concept vibes). First up is changing the code style to look like what the average peer-to-peer node.js programmer would expect from this. I added
standard
, changed code until all its rules were satisfied, and also did some renaming and tweaks here and there. There is nothing that should change runtime behavior, but be on the outlook of that in case I did a mistake.Easiest way to review is ignoring whitespaces in GitHub's diff viewer.