ssbc / secret-stack

connect peers to each other using secret-handshakes
MIT License
90 stars 19 forks source link

Convert codebase from TypeScript to JavaScript #85

Closed staltz closed 1 year ago

staltz commented 1 year ago

Benefits:

This PR is a pretty direct 1:1 mapping from TypeScript to JavaScript without additional changes.

socket-security[bot] commented 1 year ago

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/debug 4.1.8 None +1 10.5 kB types
typescript 4.5.5...5.1.6 None +0/-0 40.1 MB typescript-bot
staltz commented 1 year ago

One thing I don't know is what this new js-docs thing is or how to test it/ fix it if I break stuff. Can you put a comment in the README about what it is and how to learn more?

It's now part of the tests, when you (or CI) runs npm test, the types will be checked. The type errors (if any) are instructive enough and are shown in details in the terminal output, like a compiler should.

staltz commented 1 year ago

Thanks for reviewing!