Closed cmoid closed 1 year ago
I'm not sure I understand the addition of the BYTES_VAL
and whether it's a breaking change (if someone were to follow the spec strictly and blindly), so I'll defer to @tschudin .
oops, I misread that. I had done pattern recognition on the two and thought it missing :)
I'll resubmit the other typo when I push up my implementation, in case I find more.
@cmoid : Please note that I do not see or get notified about some PRs or discussions you had, good that @staltz referenced my handle in the comment. Great that an independent implementation is coming, and thanks for the typo fixes!
BTW: for the ESP32 side of tinySSB I now also have a C++ implementation, if that is helpful. See https://github.com/ssbc/tinySSB/blob/main/esp32/loramesh-TBeam/bipf.cpp
@tschudin
sorry I should bundle these and push them en masse. I'm implementing this spec as an elixir exercise and reading it closely.
As an aside, the reference python implementation has some missing links and the distribution leaves out some test codes also mentioned.