ssbc / sips

Secure Scuttlebutt Implementation Protocols
22 stars 5 forks source link

010: thread spec #7

Closed mixmix closed 1 year ago

mixmix commented 1 year ago

Preview HERE: https://github.com/ssbc/sips/blob/964e9a5cf407f1adf6e26f3b656c0e769f21caf4/010.md

mixmix commented 1 year ago

@staltz I want to do the minimal additional work to get this merged.

TODOs:

Prescriptive vs. educational, yes keen to see that done.

Given I don't want to do much more work on this, but we need it written down somewhere, would you be down to pair on this to get it done?

staltz commented 1 year ago

Given I don't want to do much more work on this, but we need it written down somewhere, would you be down to pair on this to get it done?

I'm your inverse, I feel less motivated when I'm pairing to get things done. I suggest we just relax the deadlines with this PR. You (or me) can come back to it some time in the future and finish the TODOs.

ahdinosaur commented 1 year ago

I don't know how forks are handled, or what the logic is because I didn't implement it. I don't think this should be held up on that

for what it's worth, thread forks should probably be a separate spec anyways.

mixmix commented 1 year ago

A wild @ahdinosaur appears! Hi <3 Yeah making it a different sip would feel nice ... or just not requiring it to be in here ...sigh

@staltz can we just merge this. It's better than nothing, and not having it in master means it's not really visible

staltz commented 1 year ago

@staltz can we just merge this. It's better than nothing, and not having it in master means it's not really visible

Nope! Let's please not push documents that have TODOs in them as official specification. If someone really wants to read something in progress, they can just open the "Pull Requests" tab and browse this.

It would also go against the REVIEWING.md which wasn't written in vain, so please don't merge things that are work in progress.

mixmix commented 1 year ago

I want to remove forks from this spec, and merge it Can we do that @staltz ? I want to be able to link to this at a stable location

mixmix commented 1 year ago

DONE - removed forks

staltz commented 1 year ago

I'll take a look, thanks

mixmix commented 1 year ago

merge squashed!