search

ssbc / ssb-bfe-spec

9 stars 1 forks source link

Remove key_length from spec data #22

Closed mycognosist closed 3 years ago

mycognosist commented 3 years ago

While reviewing one of my PR's for ssb-bfe-rs, @staltz noticed that we have redundant data in bfe.json (https://github.com/ssb-ngi-pointer/ssb-bfe-rs/pull/9#discussion_r720269293).

The encryption-key type has both a data_length and a key_length. This PR simply removes the redundant data.

I believe the next step will be to update ssb-bfe to use format.data_length in place of format.key_length in this single location: https://github.com/ssb-ngi-pointer/ssb-bfe/blob/7ea8dfe38749d496d528ec0eac30e6e670e133fb/util.js#L17

staltz commented 3 years ago

@mixmix Would be good to have your review here since you wrote that line.

staltz commented 3 years ago

Is there any one using this key field? If it's considered a mistake (should have never been there), then it doesn't count as a breaking change.

mixmix commented 3 years ago

Meh. I think make it a patch and see what explodes. Merger gets to fix it! Jokes, i think it's unlikely to break anything. I just didn't do it because I didn't want any more negotiation at the time!

On Sat, 2 Oct 2021, 08:35 André Staltz, @.***> wrote:

Is there any one using this key field? If it's considered a mistake (should have never been there), then it doesn't count as a breaking change.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssb-ngi-pointer/ssb-bfe-spec/pull/22#issuecomment-932499551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUK3HQWZNEEGVT2PK5DGJTUEYEPJANCNFSM5FEZZXUQ .

mycognosist commented 3 years ago

Thanks for taking a look, @mixmix 🙏🏻

mycognosist commented 3 years ago

Merged and published as 0.4.0.